Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify AutoACMG methods #109

Closed
gromdimon opened this issue May 27, 2024 · 0 comments · Fixed by #110
Closed

Unify AutoACMG methods #109

gromdimon opened this issue May 27, 2024 · 0 comments · Fixed by #110
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@gromdimon
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Currently we have some methods, which seem to depend on the same data. To avoid redundancy, we should combine this separate classes in some other unified abstraction.

Describe the solution you'd like
Add one central class with data setup and predict method (+ any other helper methods). And form smaller other classes for each criteria.

Describe alternatives you've considered
N/A

Additional context
N/A

@gromdimon gromdimon added the enhancement New feature or request label May 27, 2024
@gromdimon gromdimon self-assigned this May 27, 2024
@gromdimon gromdimon linked a pull request May 27, 2024 that will close this issue
@gromdimon gromdimon added this to the 0.2.0 milestone Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant