Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure seqvar_pvs1 file #24

Closed
gromdimon opened this issue Apr 2, 2024 · 0 comments · Fixed by #27
Closed

Restructure seqvar_pvs1 file #24

gromdimon opened this issue Apr 2, 2024 · 0 comments · Fixed by #27
Assignees
@gromdimon
Labels
enhancement New feature or request
Milestone
0.1.0

Comments

@gromdimon
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
The SeqVarPVS1 class is already very complex. However, the readability of the code is not the last thing to maintain!

Describe the solution you'd like
Restructure SeqVarPVS1 class by implementing "setup data" and "compute pvs1" mixins.

Describe alternatives you've considered
N/A

Additional context
N/A
@gromdimon gromdimon added the enhancement New feature or request label Apr 2, 2024
@gromdimon gromdimon added this to the 0.1.0 milestone Apr 2, 2024
@gromdimon gromdimon self-assigned this Apr 2, 2024
@gromdimon gromdimon mentioned this issue Apr 10, 2024
Merged
@gromdimon gromdimon linked a pull request Apr 10, 2024 that will close this issue
Restructure seqvar pvs1 computation logic #27
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gromdimon gromdimon

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.1.0
Development

Successfully merging a pull request may close this issue.

Restructure seqvar pvs1 computation logic bihealth/auto-acmg
1 participant
@gromdimon