Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt methods of SeqVarPVS1Helper to new annonars pydantic models #55

Closed
gromdimon opened this issue Apr 16, 2024 · 2 comments · Fixed by #91
Closed

Adapt methods of SeqVarPVS1Helper to new annonars pydantic models #55

gromdimon opened this issue Apr 16, 2024 · 2 comments · Fixed by #91
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@gromdimon
Copy link
Collaborator

gromdimon commented Apr 16, 2024

Is your feature request related to a problem? Please describe.
We need more consistency in such methods as _lof_is_frequent_in_population and _lof_removes_more_then_10_percent_of_protein after we implement real annonars pydantic models.

Describe the solution you'd like
Migrate to new annonars models.
Correct the counting of pathogenic variants in _critical4protein_function
Correct the counting of LOF variants in _lof_is_frequent_in_population

Describe alternatives you've considered
N/A

Additional context
Good for implementation with #41

@gromdimon gromdimon added the enhancement New feature or request label Apr 16, 2024
@gromdimon gromdimon added this to the 0.1.0 milestone Apr 16, 2024
@gromdimon gromdimon self-assigned this Apr 16, 2024
@gromdimon gromdimon changed the title Update methods of SeqVarPVS1Helper to be more unified Adapt methods of SeqVarPVS1Helper to new annonars pydantic models Apr 17, 2024
@gromdimon
Copy link
Collaborator Author

Should be implemented after #63

@gromdimon
Copy link
Collaborator Author

This methods were corrected in #63 since tests were failing otherwise. However, we have to increase code coverage for this methods

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant