Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase test coverage #162

Merged
merged 24 commits into from
Aug 12, 2024
Merged

Increase test coverage #162

merged 24 commits into from
Aug 12, 2024

Conversation

gromdimon
Copy link
Collaborator

Issue:

Description:

  • Rewrote unit tests
  • Fixed integration tests
  • Implemented new e2e tests

@gromdimon gromdimon linked an issue Aug 9, 2024 that may be closed by this pull request
@gromdimon gromdimon marked this pull request as draft August 9, 2024 09:49
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 95.62044% with 6 lines in your changes missing coverage. Please review.

Project coverage is 82.72%. Comparing base (58111a5) to head (c22fec7).
Report is 1 commits behind head on main.

Files Patch % Lines
src/criteria/auto_pvs1.py 70.00% 3 Missing ⚠️
src/utils.py 0.00% 2 Missing ⚠️
src/criteria/auto_pm1.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #162       +/-   ##
===========================================
+ Coverage   44.66%   82.72%   +38.05%     
===========================================
  Files          33       27        -6     
  Lines        3132     2611      -521     
===========================================
+ Hits         1399     2160      +761     
+ Misses       1733      451     -1282     
Files Coverage Δ
src/auto_acmg.py 58.64% <100.00%> (+30.61%) ⬆️
src/criteria/auto_pm4_bp3.py 98.83% <100.00%> (+73.25%) ⬆️
src/defs/auto_acmg.py 99.57% <100.00%> (+2.13%) ⬆️
src/defs/auto_pvs1.py 100.00% <100.00%> (ø)
src/defs/core.py 82.35% <100.00%> (+3.78%) ⬆️
src/defs/genome_builds.py 100.00% <100.00%> (ø)
src/defs/seqvar.py 95.91% <100.00%> (+5.29%) ⬆️
src/criteria/auto_pm1.py 83.33% <87.50%> (+60.16%) ⬆️
src/utils.py 76.55% <0.00%> (+35.22%) ⬆️
src/criteria/auto_pvs1.py 62.61% <70.00%> (+52.33%) ⬆️

... and 15 files with indirect coverage changes

@gromdimon
Copy link
Collaborator Author

gromdimon commented Aug 12, 2024

The test coverage increased.
Done:

  • Fixed old unit tests
  • New unit tests
  • E2e tests
  • Integration tests

@gromdimon gromdimon marked this pull request as ready for review August 12, 2024 15:35
@gromdimon gromdimon merged commit 853bc9e into main Aug 12, 2024
5 checks passed
@gromdimon gromdimon deleted the 134-increase-test-coverage branch August 12, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase test coverage
1 participant