Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure module in order to support other acmg rules #83

Merged

Conversation

gromdimon
Copy link
Collaborator

Issue:

Description:

  • Moved AutoPVS1 logic in separate folder
  • Unified variant resolver for all ACMG criteria
  • Updated tests

@gromdimon gromdimon linked an issue Apr 29, 2024 that may be closed by this pull request
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 61.36364% with 34 lines in your changes are missing coverage. Please review.

Project coverage is 78.81%. Comparing base (f85ce59) to head (f6268b2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
+ Coverage   75.50%   78.81%   +3.31%     
==========================================
  Files          17       17              
  Lines        1241     1232       -9     
==========================================
+ Hits          937      971      +34     
+ Misses        304      261      -43     
Files Coverage Δ
src/cli.py 95.45% <100.00%> (+0.21%) ⬆️
src/defs/seqvar.py 78.49% <83.33%> (-14.61%) ⬇️
src/pvs1/auto_pvs1.py 87.17% <80.00%> (ø)
src/defs/strucvar.py 90.62% <42.85%> (-5.87%) ⬇️
src/auto_acmg.py 66.21% <60.60%> (+66.21%) ⬆️
src/pvs1/seqvar_pvs1.py 56.53% <43.47%> (ø)

... and 1 file with indirect coverage changes

@gromdimon gromdimon merged commit 59394ba into main Apr 29, 2024
4 checks passed
@gromdimon gromdimon deleted the 66-restructure-script-in-order-to-support-other-acmg-rules branch April 29, 2024 14:49
gromdimon added a commit that referenced this pull request Aug 2, 2024
* wip

* restructure for acmg

* restructure dependencies for dev installation

* restructure different files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restructure script in order to support other acmg rules
1 participant