Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix division by error #139

Merged
merged 4 commits into from
Feb 2, 2024
Merged

Fix division by error #139

merged 4 commits into from
Feb 2, 2024

Commits on Feb 2, 2024

  1. Fix division by zero error 

    Only compare number values and not types

Fixes #127
    @lehecht
    lehecht committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    9e444ae View commit details
    Browse the repository at this point in the history

  2. Update tests

    @lehecht
    lehecht committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    86d6839 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into div-by-zero

    @lehecht
    lehecht committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    0d3cd98 View commit details
    Browse the repository at this point in the history

  4. Use strict check rather than relaxed check to fix division by zero error 

    The original check ===0 did not work if the value was 0.0.
    @mzur
    mzur committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    ad05389 View commit details
    Browse the repository at this point in the history