Skip to content

Commit

Permalink
Grab bag of test_sys_checkout cleanups:
Browse files Browse the repository at this point in the history
   Doc inside of each test more clearly/consistently.
   TestSysCheckoutSVN didn’t get the inlining-of-helper-methods treatment, now it has that.
   Move various standalone repo helper methods (like create_branch) into a RepoUtils class.
   README.md was missing newlines when rendered as markdown.
   Doc the return value of checkout.main
   Fix test_container_exclude_component - it was looking for the wrong key (which is never present); now it looks for the correct key.
  • Loading branch information
johnpaulalex committed Jan 28, 2023
1 parent 5329c8b commit fbee425
Show file tree
Hide file tree
Showing 3 changed files with 294 additions and 352 deletions.
4 changes: 2 additions & 2 deletions manic/checkout.py
Original file line number Diff line number Diff line change
Expand Up @@ -378,8 +378,8 @@ def main(args):
the --all option is passed.
Returns a tuple (overall_status, tree_status). overall_status is 0
on success, non-zero on failure. tree_status gives the full status
if no checkout is happening. If checkout is happening, tree_status
on success, non-zero on failure. tree_status is a dict mapping local path
to ExternalStatus -- if no checkout is happening. If checkout is happening, tree_status
is None.
"""
if args.do_logging:
Expand Down
4 changes: 3 additions & 1 deletion test/repos/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ git ls-tree --full-tree -r --name-only HEAD
git cat-file -p HEAD:<filename>
```

File contents at a glance:
```
container.git/
readme.txt
Expand All @@ -28,4 +30,4 @@ mixed-cont-ext.git/
error/
(no git repo here, just a readme.txt in the clear)

```
Loading

0 comments on commit fbee425

Please sign in to comment.