Add is_vehicle_tracking_enabled on Vehicle #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #370 +/- ##
==========================================
+ Coverage 96.42% 96.43% +0.01%
==========================================
Files 8 8
Lines 894 897 +3
==========================================
+ Hits 862 865 +3
Misses 32 32
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
gerard33
reviewed
Nov 30, 2021
bimmer_connected/vehicle.py
Outdated
| @@ -137,6 +137,11 @@ def has_weekly_planner_service(self) -> bool: | |||
| """Return True if charging control (weekly planner) is available.""" | |||
| return self.attributes["capabilities"]["isChargingPlanSupported"] | |||
|
|
|||
| @property | |||
| def is_vehicle_tracking_enabled(self) -> bool: | |||
| """Return True if charging control (weekly planner) is available.""" | |||
There was a problem hiding this comment.
Docstring is containing text from other function
gerard33
approved these changes
Nov 30, 2021
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Add
is_vehicle_tracking_enabledproperty onConnectedDriveVehicle(see #318 (comment)).Type of change
Additional information
Checklist