Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump X-User-Agent #426

Merged
merged 1 commit into from
Apr 21, 2022
Merged

Bump X-User-Agent #426

merged 1 commit into from
Apr 21, 2022

Conversation

muxiachuixue
Copy link
Contributor

The original version is too old. BMW API will give an error: "the App version is too old, please update".

Breaking change

Proposed change

Fix the bug warning "MyBMW version is too old, please update"

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to this library)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:

Checklist

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works.

@muxiachuixue
Update const.py
66523bb 
The original version is too old. BMW API will give an error: "the App version is too old, please update".
@rikroe rikroe changed the title Update const.py Bump X-User-Agent Apr 21, 2022
@rikroe rikroe merged commit 3d71a53 into bimmerconnected:master Apr 21, 2022
@rikroe
Copy link
Member

rikroe commented Apr 21, 2022

Many thanks!

rikroe pushed a commit to rikroe/bimmer_connected that referenced this pull request Apr 21, 2022
@muxiachuixue @rikroe
Bump X-User-Agent (bimmerconnected#426)
af674d4 
The original version is too old. BMW API will give an error: "the App version is too old, please update".
@rikroe rikroe mentioned this pull request Apr 22, 2022
Closed
4 tasks
@muxiachuixue muxiachuixue deleted the patch-1 branch April 22, 2022 05:55
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rikroe rikroe rikroe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@muxiachuixue @rikroe