Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remaining_range_total on new electric-only vehicles #469

Merged
merged 3 commits into from
Jul 15, 2022

Conversation

rikroe
Copy link
Member

@rikroe rikroe commented Jul 13, 2022

Proposed change

Fixes doubled remaining_range_total on newer electric only vehicles.

As parsing had to be based on DriveTrainType, some refactoring had to be done (mainly moving DriveTrainType into a separate file to avoid circular imports).

While implementing, it became clear that we do not need a separate attribute for range extender cars, so I removed that as well.

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to this library)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works.

@rikroe rikroe marked this pull request as ready for review July 13, 2022 21:12
@codecov-commenter
Copy link

Codecov Report

Merging #469 (3874e16) into master (117bb06) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #469   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           16        16           
  Lines         1257      1211   -46     
=========================================
- Hits          1257      1211   -46     
Flag Coverage Δ
3.10.x 100.00% <100.00%> (ø)
3.6 99.91% <100.00%> (-0.01%) ⬇️
3.7 100.00% <100.00%> (ø)
3.8 100.00% <100.00%> (ø)
3.9 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
bimmer_connected/vehicle/__init__.py 100.00% <100.00%> (ø)
bimmer_connected/vehicle/const.py 100.00% <100.00%> (ø)
bimmer_connected/vehicle/fuel_and_battery.py 100.00% <100.00%> (ø)
bimmer_connected/vehicle/vehicle.py 100.00% <100.00%> (ø)
bimmer_connected/const.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 117bb06...3874e16. Read the comment docs.

@rikroe rikroe requested a review from gerard33 July 14, 2022 20:06
@rikroe rikroe merged commit 5937d02 into bimmerconnected:master Jul 15, 2022
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 23, 2022
@rikroe rikroe deleted the fix-electric-only-range branch April 14, 2023 15:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants