Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs on using the library fingerprints in HA #599

Merged
merged 3 commits into from
Feb 18, 2024

Conversation

rikroe
Copy link
Member

@rikroe rikroe commented Feb 11, 2024

Proposed change

Updated docs :)

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to this library)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:

Checklist

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works.

@rikroe rikroe requested a review from gerard33 February 11, 2024 21:53
Copy link

codecov bot commented Feb 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f59746b) 100.00% compared to head (f10bf8d) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #599   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines         1428      1428           
=========================================
  Hits          1428      1428           
Flag Coverage Δ
3.10 100.00% <ø> (ø)
3.11 100.00% <ø> (ø)
3.12 100.00% <ø> (ø)
3.8 100.00% <ø> (ø)
3.9 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


Edit the ``_get_vehicles()`` function in `account.py#L370-L392 <https://github.com/bimmerconnected/bimmer_connected/blob/master/bimmer_connected/account.py#L370-L392>`_
and add the following code between ``self._get_oauth_token()`` and ``for brand in CarBrand:``:
Edit ``homeassistant/components/bmw_connected_drive/coordinator.py`` and locate the function ``_async_update_data``. We now have to replace ``await self.account.get_vehicles()``. The ``try .. except`` block should look like this:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This folder is not available on HA OS or Supervised installs, so good to mention that this is available on Container / Core installs (don't know what your install type is)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically the whole thing is referencing the HA dev environment (i.e. running it on your local machine in VS Code). Can I make this somehow clearer with the existing warning to the HA dev environment?

Would you run this also in your local HAOS installation (it would surely mess up a lot of settings)?

Copy link
Member

@gerard33 gerard33 Feb 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see. then good to mention in the title that this is for Home Assistant development environment. That should be clear then.

Doesn't sound logic to run this in a local HAOS installation.

@rikroe rikroe requested a review from gerard33 February 17, 2024 08:05
@rikroe rikroe merged commit bd4b15a into bimmerconnected:master Feb 18, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants