Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Store OAuth credentials in local file #626

Merged
merged 5 commits into from
Jul 6, 2024

Conversation

rikroe
Copy link
Member

@rikroe rikroe commented Jul 1, 2024

Breaking change

Every CLI command now stores the API credentials in a file for reuse in later calls. By default, data is stored to ~/.bimmer_connected.json (Mac and Linux) or C:\Users\username\.bimmer_connected.json (Windows). The file location can be changed using the --oauth-store parameter.
If you don't want the data stored, use the --disable-oauth-store parameter.

Proposed change

Store OAuth2 tokens from API for commandline calls so everybody not using Home Assistant does not have to go through a full reauthentication flow on every CLI command.

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to this library)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:

Checklist

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works.

@rikroe rikroe requested a review from gerard33 July 5, 2024 14:57
Copy link
Member

@gerard33 gerard33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@rikroe rikroe merged commit 8169b5e into bimmerconnected:master Jul 6, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants