Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

关于error日志问题 #1164

Closed
Ziyear opened this issue Aug 19, 2019 · 2 comments
Closed

关于error日志问题 #1164

Ziyear opened this issue Aug 19, 2019 · 2 comments
Labels
微信支付

Comments

@Ziyear
Copy link

Ziyear commented Aug 19, 2019

建议：
多处接口抛出error日志，简易排查尽可能去掉error替换成直接抛出异常方式
模块及版本：

  • WxJava 模块名: 微信支付
  • WxJava 版本号:3.4.0
    举例：
    测试对账单下载，发现对账单下载失败是NO Bill Exist，直接打印err日志和堆栈，异常未抛出。还有一个细节就是失败参数映射缺少err_code,原因是返回参数是error_code，导致映射失败。
    BaseWxPayServiceImpl类中还有不少error日志，建议替换掉这种处理方式，交给使用者处理。
@binarywang
Copy link
Owner

建议你直接提交PR代码来辅助展示下你的想法，感觉你的描述不够清晰

Ziyear added a commit to Ziyear/WxJava that referenced this issue Aug 20, 2019
@Ziyear
去除err日志，交给使用者处理
ad8caee 
binarywang#1164
@Ziyear Ziyear mentioned this issue Aug 20, 2019
Merged
binarywang pushed a commit that referenced this issue Aug 20, 2019
@Ziyear @binarywang
#1164 微信支付模块去除一些多余的错误日志输出
759bc62
@Ziyear
Copy link
Author

Ziyear commented Aug 20, 2019

尴尬，在页面提交好不方便，下班再提吧

binarywang pushed a commit that referenced this issue Aug 21, 2019
@Ziyear @binarywang
#1164 微信支付模块去除一些多余的错误日志输出
358850a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
微信支付
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@binarywang @Ziyear