-
-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix logic error in fill_buffer #336
Conversation
Codecov Report
@@ Coverage Diff @@
## master #336 +/- ##
==========================================
- Coverage 61.42% 61.40% -0.02%
==========================================
Files 11 11
Lines 827 824 -3
==========================================
- Hits 508 506 -2
+ Misses 319 318 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation looks fine. Is there a way to add a test with a Deserialize impl for which this makes a difference? It's weird that this wouldn't have been covered by the test suite.
I can design a small unit test that makes sure this function behaves properly. The test suite probably doesn't have complex enough types to trigger this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Closes #335