Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix logic error in fill_buffer #336

Merged
merged 4 commits into from
Jun 24, 2020
Merged

fix logic error in fill_buffer #336

merged 4 commits into from
Jun 24, 2020

Conversation

ZoeyR
Copy link
Collaborator

@ZoeyR ZoeyR commented Jun 24, 2020

Closes #335

@ZoeyR ZoeyR requested a review from dtolnay June 24, 2020 05:33
@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2020

Codecov Report

Merging #336 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #336      +/-   ##
==========================================
- Coverage   61.42%   61.40%   -0.02%     
==========================================
  Files          11       11              
  Lines         827      824       -3     
==========================================
- Hits          508      506       -2     
+ Misses        319      318       -1     
Impacted Files Coverage Δ
src/lib.rs 75.00% <ø> (ø)
src/de/read.rs 53.84% <100.00%> (-0.70%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5fa06e...40074e0. Read the comment docs.

Copy link
Contributor

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks fine. Is there a way to add a test with a Deserialize impl for which this makes a difference? It's weird that this wouldn't have been covered by the test suite.

@ZoeyR
Copy link
Collaborator Author

ZoeyR commented Jun 24, 2020

I can design a small unit test that makes sure this function behaves properly. The test suite probably doesn't have complex enough types to trigger this.

@ZoeyR ZoeyR requested a review from dtolnay June 24, 2020 06:15
Copy link
Contributor

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression in 1.3.0: memory allocation of 8391155392347897856 bytes failed
3 participants