Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract virtue #443

Merged
merged 5 commits into from
Dec 11, 2021
Merged

Extract virtue #443

merged 5 commits into from
Dec 11, 2021

Conversation

VictorKoenders
Copy link
Contributor

This PR extracts the derive framework from bincode-derive into its own crate. This crate is https://docs.rs/virtue.

Additionally fixes some minor issues

  • src/impl_core.rs now has some clippy warnings. Because this code is copied from core I've just added a #![allow(clippy::needless_borrow)] at the top
  • Clippy has a new warning to replace core::mem::replace(&mut self.slice, &mut []) with core::mem::take(&mut self.slice), so I've implemented that
  • #![crate_type = "dylib"] is now deprecated, so I've removed it

@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2021

Codecov Report

Merging #443 (038cdf7) into trunk (a067d1e) will increase coverage by 3.85%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            trunk     #443      +/-   ##
==========================================
+ Coverage   63.12%   66.97%   +3.85%     
==========================================
  Files          46       35      -11     
  Lines        3479     2604     -875     
==========================================
- Hits         2196     1744     -452     
+ Misses       1283      860     -423     
Impacted Files Coverage Δ
derive/src/derive_enum.rs 0.00% <0.00%> (ø)
derive/src/derive_struct.rs 0.00% <0.00%> (ø)
derive/src/lib.rs 0.00% <0.00%> (-5.34%) ⬇️
src/de/impl_core.rs 53.57% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a067d1e...038cdf7. Read the comment docs.

src/de/impl_core.rs Outdated Show resolved Hide resolved
@VictorKoenders VictorKoenders merged commit fffe5d9 into trunk Dec 11, 2021
@VictorKoenders VictorKoenders deleted the feature/extract-virtue branch December 11, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants