Fuzz for compatibility with bincode v1 #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## trunk #498 +/- ##
=======================================
Coverage 69.09% 69.09%
=======================================
Files 44 44
Lines 3058 3058
=======================================
Hits 2113 2113
Misses 945 945 Continue to review full report at Codecov.
|
ZoeyR
reviewed
Feb 2, 2022
fuzz/fuzz_targets/roundtrip.rs
Outdated
| @@ -40,12 +38,22 @@ enum AllTypes { | |||
| } | |||
|
|
|||
| fuzz_target!(|data: &[u8]| { | |||
| let config = bincode::config::standard().with_limit::<1024>(); | |||
| let config = bincode::config::legacy().with_limit::<1024>(); | |||
| let configv1 = bincodev1::DefaultOptions::new().with_limit(1024).allow_trailing_bytes(); | |||
There was a problem hiding this comment.
This will use varint encoding, the legacy() will use fixint. The true legacy config from bincode 1 is bincodev1::Config
|
Okay, this seems like it's correct? Unless I'm missing something else with the config (endian?). Example output is |
|
That specific issue should now be fixed in trunk. |
ZoeyR
reviewed
Feb 6, 2022
|
I'm getting Bytes: [12, 0, 0, 0, 0, 100, 0, 0, 0, 100]
Bincode V1: Ok(Ipv4Addr(0.100.0.0))
Bincode V2: Err(UnexpectedEnd)now. |
|
Fixed some compatibility issues in #503 including |
ZoeyR
approved these changes
Feb 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finds this input:
Which fails because of
Not sure if this is a bug, but making this as a draft to just make a note of it. I might want to move the compatibility check to a new fuzzer before this is merged.