Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add impls for Rc<[T]> and Arc<[T]> #552

Merged
merged 1 commit into from
Jun 15, 2022

Conversation

maciejhirsz
Copy link
Contributor

Fixes #551.

@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #552 (dac7164) into trunk (e8ccb0a) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##            trunk     #552      +/-   ##
==========================================
- Coverage   54.47%   54.44%   -0.03%     
==========================================
  Files          49       49              
  Lines        4417     4423       +6     
==========================================
+ Hits         2406     2408       +2     
- Misses       2011     2015       +4     
Impacted Files Coverage Δ
src/features/impl_alloc.rs 61.17% <0.00%> (-4.18%) ⬇️
tests/alloc.rs 93.75% <ø> (ø)
src/error.rs 0.00% <0.00%> (ø)
src/lib.rs 15.01% <0.00%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8ccb0a...dac7164. Read the comment docs.

Copy link
Contributor

@VictorKoenders VictorKoenders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@VictorKoenders VictorKoenders merged commit 18d5249 into bincode-org:trunk Jun 15, 2022
@maciejhirsz
Copy link
Contributor Author

maciejhirsz commented Jun 15, 2022

@VictorKoenders thank you! With this change I managed to successfully port all my code to bincode 2.0. I use bincode extensively for networking and a custom file format, and everything seems to work well and is backwards compatible with 1.x.

I'm okay with having git dependencies and I'm in no rush, but would appreciate 2.0.0-rc.2 at some point :)

Edit: as a bonus, without serde Wasm build of my client is now 20kb smaller 🎉.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing impls for Rc<[T]> | Arc<[T]> (2.0.0-rc.1)
2 participants