Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Default for Configuration #575

Merged
merged 2 commits into from
Aug 18, 2022
Merged

Conversation

VictorKoenders
Copy link
Contributor

Closes #567

@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #575 (66a29f4) into trunk (9dd19d9) will increase coverage by 0.41%.
The diff coverage is 33.33%.

❗ Current head 66a29f4 differs from pull request most recent head 3f43442. Consider uploading reports for the commit 3f43442 to get more accurate results

@@            Coverage Diff             @@
##            trunk     #575      +/-   ##
==========================================
+ Coverage   55.58%   56.00%   +0.41%     
==========================================
  Files          50       50              
  Lines        4305     4275      -30     
==========================================
+ Hits         2393     2394       +1     
+ Misses       1912     1881      -31     
Impacted Files Coverage Δ
src/config.rs 82.60% <33.33%> (-7.87%) ⬇️
src/error.rs 0.00% <0.00%> (ø)
src/features/impl_std.rs 66.34% <0.00%> (ø)
tests/issues/issue_500.rs 100.00% <0.00%> (ø)
src/lib.rs 16.17% <0.00%> (+0.98%) ⬆️
tests/basic_types.rs 99.32% <0.00%> (+1.32%) ⬆️
tests/derive.rs 97.76% <0.00%> (+2.08%) ⬆️
tests/std.rs 100.00% <0.00%> (+2.46%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@VictorKoenders VictorKoenders enabled auto-merge (squash) August 18, 2022 17:12
@VictorKoenders VictorKoenders merged commit 4442c9c into trunk Aug 18, 2022
@VictorKoenders VictorKoenders deleted the vko/config_default branch August 18, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

impl Default for Configuration
2 participants