Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: choose worker recipes by depth level #950

Merged
merged 3 commits into from
Apr 5, 2024
Merged

Conversation

aliciaaevans
Copy link
Contributor

@aliciaaevans aliciaaevans commented Dec 27, 2023

In an attempt to try a more efficient process for doing bulk builds, I added an option --subdag-depth (int, default: None) that will only assign recipes with a certain dependency depth to the bulk workers. Only nodes of a certain depth will be built (i.e., 0: only root nodes, 1: only nodes with parents that are root nodes, etc.). The idea is to allow someone to build all recipes that have no dependencies in the DAG, then remove those from the DAG and build the new "root" recipes. The existing behavior will still work if --subdag-depth is not included.

Currently, manual intervention is needed to do the Bioconductor bulk update because the recipes are assigned unevenly to the workers and some child nodes are dependent on recipes being built on a different worker. This new approach also requires manual intervention to increment --subdag-depth after the previous depth level is done building, but hopefully will result in fewer failures from the chain of dependencies and less time spent with one worker building while the rest sit idle.

Example of the behavior without (left) and with (right) --subdag-depth:
image

Tested on https://github.com/bioconda/bioconda-recipes/tree/bulk-performance-testing branch (action: https://github.com/bioconda/bioconda-recipes/actions/workflows/Bulk.yml).

@aliciaaevans aliciaaevans marked this pull request as ready for review January 4, 2024 15:05
@aliciaaevans aliciaaevans requested a review from daler April 5, 2024 20:39
@daler daler merged commit 4c51ae3 into master Apr 5, 2024
9 checks passed
@daler daler deleted the bulk-performance branch April 5, 2024 20:57
mbargull pushed a commit that referenced this pull request May 5, 2024
🤖 I have created a release \*beep\* \*boop\*
---
##
[2.15.0](https://www.github.com/bioconda/bioconda-utils/compare/v2.14.0...v2.15.0)
(2024-05-03)


### Features

* Add support for .conda format
([#981](https://www.github.com/bioconda/bioconda-utils/issues/981))
([125c9ea](https://www.github.com/bioconda/bioconda-utils/commit/125c9ea5e362b7e5e63dfcbfae995fa3eeb58ce8))
* choose worker recipes by depth level
([#950](https://www.github.com/bioconda/bioconda-utils/issues/950))
([4c51ae3](https://www.github.com/bioconda/bioconda-utils/commit/4c51ae31158b0154cf3ed381c4a3ad8b9bff7f14))
* Update dependencies to latest versions
([#972](https://www.github.com/bioconda/bioconda-utils/issues/972))
([dc6ca07](https://www.github.com/bioconda/bioconda-utils/commit/dc6ca07a977dfbf7cbc2d25f884dc0333d611116))
* Use conda/conda-build instead of mamba/conda-mambabuild
([#980](https://www.github.com/bioconda/bioconda-utils/issues/980))
([17cbc7f](https://www.github.com/bioconda/bioconda-utils/commit/17cbc7fb411864c7c22ff33b40682c0f43e016cc))


### Bug Fixes

* handle PR list with no items
([#975](https://www.github.com/bioconda/bioconda-utils/issues/975))
([869577a](https://www.github.com/bioconda/bioconda-utils/commit/869577a76933c2d7bcf386c1179ef454bdc18543))
* Ignore src_cache for container-built packages
([125c9ea](https://www.github.com/bioconda/bioconda-utils/commit/125c9ea5e362b7e5e63dfcbfae995fa3eeb58ce8))
* Ignore Zstandard-packed repodata artifact
([125c9ea](https://www.github.com/bioconda/bioconda-utils/commit/125c9ea5e362b7e5e63dfcbfae995fa3eeb58ce8))
* use circleci api v1.1 to avoid login error
([#982](https://www.github.com/bioconda/bioconda-utils/issues/982))
([ebafe92](https://www.github.com/bioconda/bioconda-utils/commit/ebafe92ae01dc4a573e861764a4e837bd1321af3))
---


This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants