Pipeline.get_sample_names() fix for plate-replicates #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for get_sample_names() that checks to see if the sample-sheet or pre-prep file defines replicates and returns the unique values from orig_name instead of sample-names if so.
wasade
requested changes
Oct 26, 2023
Co-authored-by: Daniel McDonald <[email protected]>
Co-authored-by: Daniel McDonald <[email protected]>
Co-authored-by: Daniel McDonald <[email protected]>
Co-authored-by: Daniel McDonald <[email protected]>
restored removed lines from good-mapping-file.txt and adjusted tests accordingly.
Pull Request Test Coverage Report for Build 6662147040
💛 - Coveralls |
antgonza
requested changes
Oct 27, 2023
sequence_processing_pipeline/tests/data/pre_prep_w_replicates.csv
Outdated
Show resolved
Hide resolved
sequence_processing_pipeline/tests/data/pre_prep_w_replicates.csv
Outdated
Show resolved
Hide resolved
|
@antgonza ready for review! |
|
Thank you @charles-cowart ; I'm actually surprised that changing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for get_sample_names() that checks to see if the sample-sheet or pre-prep file defines replicates and returns the unique values from orig_name instead of sample-names if so.