Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes error in microsetta-interface integration test #500

Merged

Conversation

charles-cowart
Copy link
Contributor

Fixes an error found when running microsetta-interface integration tests.
biocore/microsetta-interface#267

@charles-cowart
Copy link
Contributor Author

charles-cowart commented Jan 9, 2023

@cassidysymons This small fix is needed to support the microsetta-interface integration test fix. This will resolve most of the errors and partially resolve the last remaining error.

@cassidysymons
Copy link
Collaborator

Is this a functional change just to resolve issues with tests? If so, that seems like an issue with the tests, rather than the code itself. Can you explain why this change is necessary?

@charles-cowart
Copy link
Contributor Author

This isn't a functional change. We added percentage_completed to the SurveyTemplateLinkInfo model class not long ago, per @wasade's suggestion to add it to the model. It's to_api() previously only required survey_answers_id and survey_status, but we added percentage_completed as an additional parameter to add and initialize that key. Depending on when the SurveyTemplateLinkInfo object is created, percentage_completed is set to None for a new object or set to a proper value in read_survey_template().

The additional parameter is needed or else the REST API call pointing to this method will fail.

@cassidysymons
Copy link
Collaborator

Gotcha, re-read the code and it makes sense now. Thanks.

@cassidysymons cassidysymons merged commit cdce8dc into biocore:master-overhaul Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants