Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to Spanish + minor bugfixes and feature improvements #509

Merged
merged 10 commits into from
Jun 8, 2023
Merged

Updates to Spanish + minor bugfixes and feature improvements #509

merged 10 commits into from
Jun 8, 2023

Conversation

cassidysymons
Copy link
Collaborator

@cassidysymons cassidysymons commented Feb 28, 2023 •
edited
Loading

Ready for review

@cassidysymons cassidysymons changed the title Updates for Spanish (es_MX & es_ES) Updates to Spanish + minor bugfixes and feature improvements Mar 9, 2023
@cassidysymons cassidysymons marked this pull request as ready for review March 9, 2023 17:23
@cassidysymons
Copy link
Collaborator Author

@wasade FYI, the code that's reflected in this PR and biocore/microsetta-interface#274 is running on staging

@cassidysymons cassidysymons mentioned this pull request Mar 12, 2023
Closed
wasade
wasade requested changes Mar 20, 2023
View reviewed changes
Copy link
Member

@wasade wasade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor comments, thanks!

microsetta_private_api/repo/survey_template_repo.py Show resolved Hide resolved
microsetta_private_api/repo/survey_template_repo.py Show resolved Hide resolved
microsetta_private_api/db/patches/0115.sql Show resolved Hide resolved
microsetta_private_api/repo/tests/test_survey_template_repo.py Show resolved Hide resolved
@wasade
Copy link
Member

wasade commented Jun 6, 2023

Just two minor items, thanks!

@cassidysymons
Copy link
Collaborator Author

@wasade Good catch, thanks! Fixed so this should be good once workflow finishes.

@wasade wasade merged commit be3e4b1 into master-overhaul Jun 8, 2023
@wasade
Copy link
Member

wasade commented Jun 8, 2023

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wasade wasade wasade requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cassidysymons @wasade