Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vocab for sample issues #574

Merged
merged 14 commits into from
Jul 30, 2024
Merged

vocab for sample issues #574

merged 14 commits into from
Jul 30, 2024

Conversation

ayobi
Copy link
Contributor

@ayobi ayobi commented May 13, 2024

Adding a fixed vocabulary of potential sample issues to the Scan Barcode tool.

@ayobi ayobi changed the title vocab for samples issues vocab for sample issues May 13, 2024
cassidysymons
cassidysymons requested changes Jun 3, 2024
View reviewed changes
microsetta_private_api/db/patches/0139.sql Outdated Show resolved Hide resolved
microsetta_private_api/db/patches/0139.sql Outdated Show resolved Hide resolved
microsetta_private_api/db/patches/0139.sql Outdated Show resolved Hide resolved
microsetta_private_api/db/patches/0139.sql Outdated Show resolved Hide resolved
microsetta_private_api/db/patches/0139.sql Outdated Show resolved Hide resolved
microsetta_private_api/db/patches/0139.sql Outdated Show resolved Hide resolved
microsetta_private_api/db/patches/0139.sql Outdated Show resolved Hide resolved
microsetta_private_api/admin/tests/test_admin_repo.py Outdated Show resolved Hide resolved
microsetta_private_api/admin/tests/test_admin_repo.py Show resolved Hide resolved
cassidysymons
cassidysymons requested changes Jun 6, 2024
View reviewed changes
microsetta_private_api/db/patches/0140.sql Outdated Show resolved Hide resolved
microsetta_private_api/db/patches/0140.sql Outdated Show resolved Hide resolved
microsetta_private_api/repo/admin_repo.py Outdated Show resolved Hide resolved
microsetta_private_api/repo/admin_repo.py Outdated Show resolved Hide resolved
microsetta_private_api/repo/admin_repo.py Outdated Show resolved Hide resolved
microsetta_private_api/repo/admin_repo.py Show resolved Hide resolved
cassidysymons
cassidysymons requested changes Jun 18, 2024
View reviewed changes
microsetta_private_api/db/patches/0140.sql Outdated Show resolved Hide resolved
microsetta_private_api/repo/admin_repo.py Outdated Show resolved Hide resolved
microsetta_private_api/repo/admin_repo.py Outdated Show resolved Hide resolved
microsetta_private_api/admin/admin_impl.py Outdated Show resolved Hide resolved
microsetta_private_api/admin/admin_impl.py Outdated Show resolved Hide resolved
microsetta_private_api/admin/admin_impl.py Outdated Show resolved Hide resolved
@cassidysymons
Copy link
Collaborator

@ayobi Can you please merge biocore:master into ayobi:vocab_samples_issues? There's a database patch missing that causes the patching process to fail. Thanks.

@ayobi
Copy link
Contributor Author

ayobi commented Jul 5, 2024

@cassidysymons merged 🎉

cassidysymons
cassidysymons requested changes Jul 9, 2024
View reviewed changes
Copy link
Collaborator

@cassidysymons cassidysymons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor adjustments, then this should be good to merge. Thanks!

microsetta_private_api/admin/tests/test_admin_repo.py Outdated Show resolved Hide resolved
microsetta_private_api/admin/tests/test_admin_repo.py Outdated Show resolved Hide resolved
@cassidysymons cassidysymons mentioned this pull request Jul 9, 2024
Merged
@cassidysymons cassidysymons merged commit 233e89c into biocore:master Jul 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cassidysymons cassidysymons cassidysymons requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ayobi @cassidysymons