Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove local functionalities implemted in Orange #1031

Merged
merged 3 commits into from
Jan 12, 2024

Conversation

PrimozGodec
Copy link
Collaborator

@PrimozGodec PrimozGodec commented Jan 12, 2024

Issue

After the new year, two tests started to warn that changes could be made

Description of changes
  • Commit 1: In Corpus, copying of attributes dictionary is no longer required since it is now implemented in Orange [FIX] Table - copy attributes when creating table from table orange3#6189
  • Commit 2: enum2int is also implemented in Orange >=3.35 and can be used from there; hence, the local implementation is removed
  • Commit 3: When I removed copying of the attributes dict, I realized retain_preprocessing is also copying this dict. Since it is handled by Orange, I removed copying in retain_preprocessing.
Includes
  • Code changes
  • Tests
  • Documentation

@PrimozGodec PrimozGodec marked this pull request as ready for review January 12, 2024 09:10
@PrimozGodec PrimozGodec changed the title Fix deprecations Remove local functionalities implemted in Orange Jan 12, 2024
@codecov-commenter
Copy link

Codecov Report

Merging #1031 (f519388) into master (02b1892) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1031      +/-   ##
==========================================
- Coverage   82.20%   82.16%   -0.05%     
==========================================
  Files          93       92       -1     
  Lines       12295    12283      -12     
  Branches     1670     1670              
==========================================
- Hits        10107    10092      -15     
- Misses       1880     1882       +2     
- Partials      308      309       +1     

@VesnaT VesnaT merged commit e7c360d into biolab:master Jan 12, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants