Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: v3 #200

Merged
merged 85 commits into from
Aug 21, 2024
Merged

feat: v3 #200

merged 85 commits into from
Aug 21, 2024

Conversation

nhedger
Copy link
Member

@nhedger nhedger commented Apr 21, 2024

What’s changing

Projects

This new version introduces the concept of projects, which aims to provide a comprehensive solution for running multiple independent Biome LSP sessions across different workspace folders or even individual folders within a mono-repository layout.

Unless explicitly told otherwise, the extension will automatically and transparently create a single project for each workspace folder present in the workspace.

This new version introduces the biome.projects configuration setting to support more complex use cases such as mono-repositories. This setting may be used to explicitly define projects at the workspace level or at the workspace folder level. This setting is ignored when defined globally, as it makes no sense in this case.

In summary, projects open up the possibility of running different versions of Biome in different parts of the user’s code base, with the possibility to use dedicated configuration files if necessary.

Global LSP session

Up until now, the extension used the first available LSP to provide Biome support to Untitled files (files that haven’t yet been saved to disk). While usually not an issue in single-root workspaces, this approach is less ideal in multi-root workspaces where the LSP you’d get depended on the order in which the workspace folders had been opened/added.

To tackle this issue, the extension introduces an on-demand global LSP session dedicated to providing Biome features to Untitled files, and files opened in single-file mode. In workspace mode, this session is automatically destroyed to preserve resources once no more Untitled files are opened in the editor.

Platform-specific binaries

The new biome.lsp.bin configuration setting, which replaces biome.bin brings support for platform-specific binaries. Users will be able to specify the value either a string, or an object that maps platforms to their respective binaries.

Using a string

{
  "biome.lsp.bin": "/path/to/biome"
}

Using an object

{
  "biome.lsp.bin": {
    "linux-x64": "/path/to/biome",
    "linux-arm64-musl": "/path/to/biome",
    "darwin-arm64": "/path/to/biome",
    "win32-x64": "/path/to/biome.exe"
  }
}

@nhedger nhedger changed the title v3 feat: v3 Apr 21, 2024
@nhedger nhedger mentioned this pull request Apr 21, 2024
Closed
@nhedger nhedger linked an issue Apr 21, 2024 that may be closed by this pull request
Closed
@nhedger nhedger marked this pull request as ready for review August 21, 2024 07:49
@nhedger nhedger merged commit 235a245 into main Aug 21, 2024
3 checks passed
@nhedger nhedger deleted the v3 branch August 21, 2024 07:51
@ffMathy
Copy link

ffMathy commented Aug 22, 2024

Very cool. When does this release?

@nemchik
Copy link

nemchik commented Aug 22, 2024

Very cool. When does this release?

When it's ready.

@nhedger
Copy link
Member Author

nhedger commented Aug 22, 2024

Feel free to try out the nightly. It's still a bit rough around the edges though!

If you see anything suspicious let me know.

@ffMathy
Copy link

ffMathy commented Aug 22, 2024

Sure, will do! Very excited about this release. Can't wait (in case that wasn't obvious already) ❤️ 😄

@raix
Copy link

raix commented Aug 22, 2024

@nhedger Thank you, been following 💪 and will give it a spin on PlatformPlatform ❤️ 🚀

@nathggns
Copy link

Where's the best place to report issues with this? Relative paths don't seem to be working right now

@nhedger
Copy link
Member Author

nhedger commented Aug 22, 2024

Where's the best place to report issues with this? Relative paths don't seem to be working right now

An issue in this repo is fine, thanks !

@ffMathy
Copy link

ffMathy commented Sep 3, 2024

Can we release it as a pre-release VS Code extension, so it's easier to consume and try out?

@nhedger
Copy link
Member Author

nhedger commented Sep 3, 2024

Already has been. Pre release channel is v3

@ffMathy
Copy link

ffMathy commented Sep 5, 2024

I get the following in the Biome output window:

2024-09-04 07:26:25.373 [info] Biome extension activated
2024-09-04 07:26:25.864 [error] Failed to start Biome extension
2024-09-04 07:26:25.864 [info] Biome extension started

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

V3
6 participants