Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show advice messages to help to fix lint error with error message #1391

Closed
mehm8128 opened this issue Dec 31, 2023 · 5 comments · Fixed by #1551
Closed

Show advice messages to help to fix lint error with error message #1391

mehm8128 opened this issue Dec 31, 2023 · 5 comments · Fixed by #1551
Labels
A-Linter Area: linter good first issue Good for newcomers S-Enhancement Status: Improve an existing feature

Comments

@mehm8128
Copy link
Contributor

mehm8128 commented Dec 31, 2023

I have discussed in #1390
react-hooks/exhaustive-deps shows advice message including concrete missing variable names with error message such as React Hook useEffect has a missing dependency: 'missingVariableName'. Either include it or remove the dependency array., but biome VSCode extension shows only error message such as This hook specifies more dependencies than necessary. when we use useExhaustiveDependencies rule.
With concrete missing variable names, we can quickly fix lint error. So I want you to consider about it.

@ematipico ematipico transferred this issue from biomejs/biome-vscode Dec 31, 2023
@ematipico ematipico added A-Linter Area: linter S-Enhancement Status: Improve an existing feature good first issue Good for newcomers labels Dec 31, 2023
@ematipico
Copy link
Member

@mehm8128 I moved it here because the diagnostics is something that part of the core repository, not the VSCode extension

@mehm8128
Copy link
Contributor Author

Sorry, Thank you🙏

@SuperKruse
Copy link

esLint have a quick fix for it, that either adds or removes the necessary dependencies.
Would it be possible to add that functionality?

@ematipico
Copy link
Member

esLint have a quick fix for it, that either adds or removes the necessary dependencies.
Would it be possible to add that functionality?

I think it's best to create a new issue for that. Creating a code action isn't as simple as changing a phrase in the diagnostic.

@mehm8128
Copy link
Contributor Author

mehm8128 commented Jan 4, 2024

For this issue, is it ok that we only show missing or excessive variable names with error message such as This hook specifies more dependencies than necessary: 'excessiveVariable'?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Linter Area: linter good first issue Good for newcomers S-Enhancement Status: Improve an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants