-
-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(linter): show dependency variable name by useExhaustiveDependencies #1551
feat(linter): show dependency variable name by useExhaustiveDependencies #1551
Conversation
✅ Deploy Preview for biomejs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…ncies rule shows errors
a67eb8c
to
8e3d878
Compare
CodSpeed Performance ReportMerging #1551 will not alter performanceFalling back to comparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, but I’m not sure why the performance reports a regression. I don’t see anything in the PR that I would expect to be responsible. Hopefully someone else can chime in too.
Let's wait to merge this PR, we have some fixes we want to ship first, unless we want to flag this as a fix. |
Summary
As written below issue, I want
useExhaustiveDependencies
rule to show dependency variable names even when we look errors on VSCode, so I added dependency variable names on error message.close #1391
I have no confidence in my PR, so if my approach isn't good or something wrong, please tell me.
Test Plan
Please look over changed snapshot test files.