Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): show dependency variable name by useExhaustiveDependencies #1551

Conversation

mehm8128
Copy link
Contributor

Summary

As written below issue, I want useExhaustiveDependencies rule to show dependency variable names even when we look errors on VSCode, so I added dependency variable names on error message.
close #1391

I have no confidence in my PR, so if my approach isn't good or something wrong, please tell me.

Test Plan

Please look over changed snapshot test files.

Copy link

netlify bot commented Jan 13, 2024

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit 0bc2021
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/65a291d9971f61000838a00b
😎 Deploy Preview https://deploy-preview-1551--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added A-Linter Area: linter A-Website Area: website L-JavaScript Language: JavaScript and super languages L-CSS Language: CSS A-Changelog Area: changelog labels Jan 13, 2024
@mehm8128 mehm8128 force-pushed the feat/include_variable_name_in_exhaustive_dependencie_check_error branch from a67eb8c to 8e3d878 Compare January 13, 2024 12:21
@mehm8128 mehm8128 changed the title feat(analyzer): show dependency variable name by useExhaustiveDependencies feat(linter): show dependency variable name by useExhaustiveDependencies Jan 13, 2024
Copy link

codspeed-hq bot commented Jan 13, 2024

CodSpeed Performance Report

Merging #1551 will not alter performance

⚠️ No base runs were found

Falling back to comparing mehm8128:feat/include_variable_name_in_exhaustive_dependencie_check_error (0bc2021) with main (029ec57)

Summary

✅ 93 untouched benchmarks

@github-actions github-actions bot removed the L-CSS Language: CSS label Jan 13, 2024
Copy link
Contributor

@arendjr arendjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but I’m not sure why the performance reports a regression. I don’t see anything in the PR that I would expect to be responsible. Hopefully someone else can chime in too.

@ematipico
Copy link
Member

Let's wait to merge this PR, we have some fixes we want to ship first, unless we want to flag this as a fix.

@ematipico ematipico merged commit 5981f93 into biomejs:main Jan 16, 2024
19 checks passed
ematipico pushed a commit to DaniGuardiola/biome that referenced this pull request Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Linter Area: linter A-Website Area: website L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show advice messages to help to fix lint error with error message
3 participants