Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(website): Improve rebranding theming & home #1115

Merged
merged 2 commits into from
Dec 8, 2023
Merged

feat(website): Improve rebranding theming & home #1115

merged 2 commits into from
Dec 8, 2023

Conversation

yanthomasdev
Copy link
Contributor

@yanthomasdev yanthomasdev commented Dec 8, 2023

Summary

This PR continues the changes made to move into the v2 website, namely:

  • Fixed some issues on the homepage (card content not accessible for translators, missing sponsors, horizontal scrollbar, etc.)
  • Changed the light theme colors to the closest possible with enough contrast.
  • Added some missing assets for the website: new avatar logo for team/core blog post author, og image, favicon. (Keep the old logo used in blog posts for historical reasons).

Test Plan

  • I've run a few a11y tests in pages to ensure no color contrast issues continued
  • Visually tested components and all blog pages + playground for any missing assets

@yanthomasdev yanthomasdev requested a review from a team as a code owner December 8, 2023 01:04
Copy link

netlify bot commented Dec 8, 2023

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit 452c912
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/65726b95d9d9a00008a1a4f7
😎 Deploy Preview https://deploy-preview-1115--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the A-Website Area: website label Dec 8, 2023
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked and everything is fine now. The contrast issues are gone! Thank you @Yan-Thomas for these massive improvements!

@ematipico ematipico merged commit de2305c into biomejs:website-v2 Dec 8, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Website Area: website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants