Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: HTML grammar #1544

Merged
merged 3 commits into from
Jan 12, 2024
Merged

feat: HTML grammar #1544

merged 3 commits into from
Jan 12, 2024

Conversation

ematipico
Copy link
Member

Summary

This PR adds some boilerplate for HTML grammar.

It only adds code generation and a small part of the grammar.

Test Plan

CI should pass

Copy link

netlify bot commented Jan 12, 2024

Deploy Preview for biomejs canceled.

Name Link
🔨 Latest commit 8303eac
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/65a15f6012116a0008d93ce8

@github-actions github-actions bot added the A-Tooling Area: internal tools label Jan 12, 2024
Copy link
Contributor

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 49701 49701 0
Passed 48721 48721 0
Failed 980 980 0
Panics 0 0 0
Coverage 98.03% 98.03% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6322 6322 0
Passed 2036 2036 0
Failed 4286 4286 0
Panics 0 0 0
Coverage 32.20% 32.20% 0.00%

ts/babel

Test result main count This PR count Difference
Total 662 662 0
Passed 592 592 0
Failed 70 70 0
Panics 0 0 0
Coverage 89.43% 89.43% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 17646 17646 0
Passed 13452 13452 0
Failed 4192 4192 0
Panics 2 2 0
Coverage 76.23% 76.23% 0.00%

Copy link

codspeed-hq bot commented Jan 12, 2024

CodSpeed Performance Report

Merging #1544 will not alter performance

Comparing feat/html-grammar (8303eac) with main (a100bec)

Summary

✅ 93 untouched benchmarks

Copy link
Contributor

@denbezrukov denbezrukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Epic!🙈

@ematipico ematipico merged commit 3bd7a9c into main Jan 12, 2024
21 checks passed
@ematipico ematipico deleted the feat/html-grammar branch January 12, 2024 20:50
@Conaclos Conaclos added the A-Changelog Area: changelog label Jan 22, 2024
ematipico added a commit to DaniGuardiola/biome that referenced this pull request Jan 24, 2024
@ematipico ematipico mentioned this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Tooling Area: internal tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants