Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(formatter): apply line ending option #1591

Merged
merged 1 commit into from
Jan 18, 2024
Merged

fix(formatter): apply line ending option #1591

merged 1 commit into from
Jan 18, 2024

Conversation

ematipico
Copy link
Member

Summary

Closes #1178

Test Plan

Added a new test case, no snapshot because it's useless in this case.

@ematipico ematipico requested review from a team January 18, 2024 13:46
Copy link

netlify bot commented Jan 18, 2024

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit fe16e90
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/65a92bd3a2b930000858f7bf
😎 Deploy Preview https://deploy-preview-1591--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added A-CLI Area: CLI A-Project Area: project A-Formatter Area: formatter A-Website Area: website A-Changelog Area: changelog labels Jan 18, 2024
Copy link

codspeed-hq bot commented Jan 18, 2024

CodSpeed Performance Report

Merging #1591 will improve performances by 40.88%

Comparing fix/line-ending (fe16e90) with main (4cefa72)

Summary

⚡ 1 improvements
✅ 92 untouched benchmarks

Benchmarks breakdown

Benchmark main fix/line-ending Change
big5-added.json[cached] 3.2 ms 2.3 ms +40.88%

@ematipico ematipico merged commit 935bf9d into main Jan 18, 2024
22 checks passed
@ematipico ematipico deleted the fix/line-ending branch January 18, 2024 14:23
ematipico added a commit to DaniGuardiola/biome that referenced this pull request Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-CLI Area: CLI A-Formatter Area: formatter A-Project Area: project A-Website Area: website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📝 biome format . is trying to replace CRLF with LF on windows even with lineEnding: crlf
1 participant