release: 1.6.0

.github/ISSUE_TEMPLATE/01_formatter_bug.yml

@@ -15,7 +15,7 @@ body:
     id: environment
     attributes:
       label: Environment information
-      description: Run the command `biome rage` and paste its output here. Please review it, in case there are sensitive information you don't want to share.
+      description: Run the command `biome rage --formatter` and paste its output here. Please review it, in case there are sensitive information you don't want to share.
       render: bash
     validations:
       required: true

.github/ISSUE_TEMPLATE/02_lint_bug.yml

@@ -15,7 +15,7 @@ body:
     id: environment
     attributes:
       label: Environment information
-      description: Run the command `biome rage` and paste its output here. Please review it, in case there are sensitive information you don't want to share.
+      description: Run the command `biome rage --linter` and paste its output here. Please review it, in case there are sensitive information you don't want to share.
       render: bash
     validations:
       required: true

CHANGELOG.md

@@ -9,7 +9,7 @@ New entries must be placed in a section entitled `Unreleased`.
 Read
 our [guidelines for writing a good changelog entry](https://github.com/biomejs/biome/blob/main/CONTRIBUTING.md#changelog).
 
-## Unreleased
+## 1.6.0 (TBD)
 
 ### Analyzer
 
@@ -22,8 +22,8 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b
   ---
   - import { getLocale } from "astro:i18n";
   - import { Code } from "astro:components";
-  + import { getLocale } from "astro:i18n";
   + import { Code } from "astro:components";
+  + import { getLocale } from "astro:i18n";
   ---
 
   <div></div>
@@ -317,6 +317,47 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b
 
 ### Linter
 
+#### Promoted rules
+
+New rules are incubated in the nursery group.
+Once stable, we promote them to a stable group.
+The following rules are promoted:
+
+- [complexity/noEmptyTypeParameters](https://biomejs.dev/linter/rules/no-empty-type-parameters)
+- [complexity/noUselessLoneBlockStatements](https://biomejs.dev/linter/rules/no-useless-lone-block-statements)
+- [correctness/noUnusedImports](https://biomejs.dev/linter/rules/no-unused-imports)
+- [correctness/noInvalidUseBeforeDeclaration](https://biomejs.dev/linter/rules/no-invalid-use-before-declaration)
+- [correctness/noUnusedPrivateClassMembers](https://biomejs.dev/linter/rules/no-unused-private-class-members)
+- [correctness/useAwait](https://biomejs.dev/linter/rules/use-await)
+- [security/noGlobalEval](https://biomejs.dev/linter/rules/no-global-eval)
+- [style/useConsistentArrayType](https://biomejs.dev/linter/rules/use-consistent-array-type)
+- [style/useExportType](https://biomejs.dev/linter/rules/use-export-type)
+- [style/useFilenamingConvention](https://biomejs.dev/linter/rules/use-filenaming-convention)
+- [style/useForOf](https://biomejs.dev/linter/rules/use-for-of)
+- [style/useImportType](https://biomejs.dev/linter/rules/use-import-type)
+- [style/useNodejsImportProtocol](https://biomejs.dev/linter/rules/use-nodejs-import-protocol)
+- [style/useNumberNamespace](https://biomejs.dev/linter/rules/use-number-namespace)
+- [style/useShorthandFunctionType](https://biomejs.dev/linter/rules/use-shorthand-function-type)
+- [suspicious/noEmptyBlockStatements](https://biomejs.dev/linter/rules/no-empty-block-statements)
+- [suspicious/noGlobalAssign](https://biomejs.dev/linter/rules/no-global-assign)
+- [suspicious/noMisleadingCharacterClass](https://biomejs.dev/linter/rules/no-misleading-character-class)
+- [suspicious/noThenProperty](https://biomejs.dev/linter/rules/no-then-property)
+
+Additionally, the following rules are now recommended:
+
+- [suspicious/noApproximativeNumericConstant](https://biomejs.dev/linter/rules/no-approximative-numeric-constant)
+- [suspicious/noMisrefactoredShorthandAssign](https://biomejs.dev/linter/rules/no-misrefactored-shorthand-assign)
+
+#### Removed rules
+
+- Remove [nursery/useGroupedTypeImport](https://biomejs.dev/linter/rules/use-grouped-type-import).
+
+  [style/useImportType](https://biomejs.dev/linter/rules/use-import-type) covers the behavior of this rule.
+
+  Note that removing a nursery rule is not breaking change according to our [versionning phillosophy](https://biomejs.dev/internals/versioning).
+
+  Contributed by @Conaclos
+
 #### New features
 
 - Add the rule [noSkippedTests](https://biomejs.dev/linter/rules/no-skipped-tests), to disallow skipped tests:
@@ -364,8 +405,7 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b
   <div></div>
   ```
 
-- Add partial support for `.vue` files. Biome is able to lint and fix the script block of the Vue files. Contributed by
-  @nhedger
+- Add partial support for `.vue` files. Biome is able to lint and fix the script block of the Vue files.
 
   ```diff
   <script setup lang="ts">
@@ -376,6 +416,8 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b
   <template></template>
   ```
 
+  Contributed by @nhedger
+
 - Add rule [useNodeAssertStrict](https://biomejs.dev/linter/rules/use-node-assert-strict), which promotes the use
   of `node:assert/strict` over `node:assert`. Contributed by @ematipico
 
@@ -479,6 +521,13 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b
 
   Contributed by @Conaclos
 
+- [noUnusedVariables](https://biomejs.dev/linter/rules/no-unused-variables) no longer reports unused imports.
+
+  We now have a dedicated rule for reporting unused imports:
+  [noUnusedImpoorts](https://biomejs.dev/linter/rules/no-unused-imports)
+
+  Contributed by @Conaclos
+
 #### Bug fixes
 
 - Fix missing link in [noStaticOnlyClass](https://biomejs.dev/linter/rules/no-static-only-class) documentation.
@@ -638,7 +687,7 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b
 
 #### New features
 
-- Add option `json.formatter.trailingComma`, to provide a better control over the trailing comma in JSON/JSONC files. Its default value is `"none"`.
+- Add option `json.formatter.trailingCommas`, to provide a better control over the trailing comma in JSON/JSONC files. Its default value is `"none"`.
 
 #### Bug fixes
 

crates/biome_cli/src/execute/process_file/check.rs

@@ -20,7 +20,9 @@ pub(crate) fn check_file<'ctx>(
                 let lint_result = lint_with_guard(ctx, &mut workspace_file);
                 match lint_result {
                     Ok(status) => {
-                        changed = status.is_changed();
+                        if status.is_changed() {
+                            changed = true
+                        }
                         if let FileStatus::Message(msg) = status {
                             if msg.is_error() {
                                 has_errors = true
@@ -38,7 +40,9 @@ pub(crate) fn check_file<'ctx>(
                 let organize_imports_result = organize_imports_with_guard(ctx, &mut workspace_file);
                 match organize_imports_result {
                     Ok(status) => {
-                        changed = status.is_changed();
+                        if status.is_changed() {
+                            changed = true
+                        }
                         if let FileStatus::Message(msg) = status {
                             if msg.is_error() {
                                 has_errors = true
@@ -57,7 +61,9 @@ pub(crate) fn check_file<'ctx>(
                 let format_result = format_with_guard(ctx, &mut workspace_file);
                 match format_result {
                     Ok(status) => {
-                        changed = status.is_changed();
+                        if status.is_changed() {
+                            changed = true
+                        }
                         if let FileStatus::Message(msg) = status {
                             if msg.is_error() {
                                 has_errors = true

crates/biome_cli/tests/snapshots/main_commands_check/applies_organize_imports.snap

@@ -19,7 +19,7 @@ import * as something from "../something";
 # Emitted Messages
 
 ```block
-Checked 1 file in <TIME>. No fixes needed.
+Checked 1 file in <TIME>. Fixed 1 file.
 ```
 
 

crates/biome_cli/tests/snapshots/main_commands_check/apply_suggested.snap

@@ -13,7 +13,7 @@ console.log(a);
 # Emitted Messages
 
 ```block
-Checked 1 file in <TIME>. No fixes needed.
+Checked 1 file in <TIME>. Fixed 1 file.
 ```
 
 

crates/biome_cli/tests/snapshots/main_commands_check/check_help.snap

@@ -70,8 +70,8 @@ The configuration that is contained inside the file `biome.json`
                               languages) files.
         --json-formatter-line-width=NUMBER  What's the max width of a line applied to JSON (and its super
                               languages) files. Defaults to 80.
-        --json-formatter-trailing-commas=<omit|allow>  Print trailing commas wherever possible in multi-line
-                              comma-separated syntactic structures. Defaults to "omit".
+        --json-formatter-trailing-commas=<none|all>  Print trailing commas wherever possible in multi-line
+                              comma-separated syntactic structures. Defaults to "none".
 
 Global options applied to all commands
         --colors=<off|force>  Set the formatting mode for markup: "off" prints everything as plain text,

crates/biome_cli/tests/snapshots/main_commands_check/fs_files_ignore_symlink.snap

@@ -13,7 +13,7 @@ rome.json internalError/fs ━━━━━━━━━━━━━━━━━
 ```
 
 ```block
-Checked 2 files in <TIME>. No fixes needed.
+Checked 2 files in <TIME>. Fixed 2 files.
 ```
 
 

crates/biome_cli/tests/snapshots/main_commands_check/should_organize_imports_diff_on_check.snap

@@ -13,7 +13,7 @@ import * as something from "../something";
 # Emitted Messages
 
 ```block
-Checked 1 file in <TIME>. No fixes needed.
+Checked 1 file in <TIME>. Fixed 1 file.
 ```
 
 

crates/biome_cli/tests/snapshots/main_commands_ci/ci_help.snap

@@ -72,8 +72,8 @@ The configuration that is contained inside the file `biome.json`
                               languages) files.
         --json-formatter-line-width=NUMBER  What's the max width of a line applied to JSON (and its super
                               languages) files. Defaults to 80.
-        --json-formatter-trailing-commas=<omit|allow>  Print trailing commas wherever possible in multi-line
-                              comma-separated syntactic structures. Defaults to "omit".
+        --json-formatter-trailing-commas=<none|all>  Print trailing commas wherever possible in multi-line
+                              comma-separated syntactic structures. Defaults to "none".
 
 Global options applied to all commands
         --colors=<off|force>  Set the formatting mode for markup: "off" prints everything as plain text,

crates/biome_cli/tests/snapshots/main_commands_format/format_help.snap

@@ -106,8 +106,8 @@ Available options:
                               languages) files.
         --json-formatter-line-width=NUMBER  What's the max width of a line applied to JSON (and its super
                               languages) files. Defaults to 80.
-        --json-formatter-trailing-commas=<omit|allow>  Print trailing commas wherever possible in multi-line
-                              comma-separated syntactic structures. Defaults to "omit".
+        --json-formatter-trailing-commas=<none|all>  Print trailing commas wherever possible in multi-line
+                              comma-separated syntactic structures. Defaults to "none".
         --stdin-file-path=PATH  Use this option when you want to format code piped from `stdin`, and
                               print the output to `stdout`.
                               The file doesn't need to exist on disk, what matters is the extension of

crates/biome_cli/tests/snapshots/main_commands_rage/with_linter_configuration.snap

@@ -61,7 +61,8 @@ Environment:
   NODE_PACKAGE_MANAGER:         unset
 
 Biome Configuration:
-  Status:                       Loaded successfully
+  Error:                        Found an unknown key `useConsistentArrayType`.
+  Status:                       Loaded with errors
   Formatter disabled:           false
   Linter disabled:              false
   Organize imports disabled:    false
@@ -74,7 +75,6 @@ Linter:
                                 a11y/noAutofocus = "off"
                                 complexity/recommended = true
                                 correctness/all = true
-                                nursery/useConsistentArrayType = {"level":"warn","options":{"syntax":"shorthand"}}
                                 style/noNonNullAssertion = "off"
                                 suspicious/noCommentText = {"level":"warn","options":null}
 

crates/biome_cli/tests/snapshots/main_configuration/incorrect_rule_name.snap

@@ -59,6 +59,7 @@ biome.json:6:13 deserialize ━━━━━━━━━━━━━━━━━
   - noInnerDeclarations
   - noInvalidConstructorSuper
   - noInvalidNewBuiltin
+  - noInvalidUseBeforeDeclaration
   - noNewSymbol
   - noNonoctalDecimalEscape
   - noPrecisionLoss
@@ -73,10 +74,13 @@ biome.json:6:13 deserialize ━━━━━━━━━━━━━━━━━
   - noUnreachableSuper
   - noUnsafeFinally
   - noUnsafeOptionalChaining
+  - noUnusedImports
   - noUnusedLabels
+  - noUnusedPrivateClassMembers
   - noUnusedVariables
   - noVoidElementsWithChildren
   - noVoidTypeReturn
+  - useAwait
   - useExhaustiveDependencies
   - useHookAtTopLevel
   - useIsNan
@@ -120,17 +124,25 @@ biome.json:9:13 deserialize ━━━━━━━━━━━━━━━━━
   - useAsConstAssertion
   - useBlockStatements
   - useCollapsedElseIf
+  - useConsistentArrayType
   - useConst
   - useDefaultParameterLast
   - useEnumInitializers
   - useExponentiationOperator
+  - useExportType
+  - useFilenamingConvention
+  - useForOf
   - useFragmentSyntax
+  - useImportType
   - useLiteralEnumMembers
   - useNamingConvention
+  - useNodejsImportProtocol
+  - useNumberNamespace
   - useNumericLiterals
   - useSelfClosingElements
   - useShorthandArrayType
   - useShorthandAssign
+  - useShorthandFunctionType
   - useSingleCaseStatement
   - useSingleVarDeclarator
   - useTemplate