Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add more useImportType examples to docs #2307

Merged
merged 3 commits into from
Apr 23, 2024
Merged

docs: Add more useImportType examples to docs #2307

merged 3 commits into from
Apr 23, 2024

Conversation

drwpow
Copy link
Contributor

@drwpow drwpow commented Apr 4, 2024

Summary

Related to #2293 (closed), which was me misunderstanding if Biome was understanding the import { type } prefix correctly. It was, but my examples weren’t documented as “valid” or “invalid” so this PR adds my cases. No code changes, just updates docs (and tests). This is an opinionated change, so feel free to change/review/modify as-needed (or close if it isn’t a helpful docs addition).

Test Plan

  • Updates tests

Copy link

netlify bot commented Apr 4, 2024

Deploy Preview for biomejs failed. Why did it fail? →

Name Link
🔨 Latest commit 5fa2894
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/660ebd03a99e08000874c621

@github-actions github-actions bot added A-Linter Area: linter A-Website Area: website L-JavaScript Language: JavaScript and super languages labels Apr 4, 2024
Copy link
Member

@Conaclos Conaclos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Hopefully this will help new users to understand the scope of the rule :)

Copy link

codspeed-hq bot commented Apr 4, 2024

CodSpeed Performance Report

Merging #2307 will improve performances by 78.05%

Comparing drwpow:chore/use-import-type-docs (ef55efe) with main (2ecfe4c)

Summary

⚡ 1 improvements
✅ 92 untouched benchmarks

Benchmarks breakdown

Benchmark main drwpow:chore/use-import-type-docs Change
big5-added.json[uncached] 4.9 ms 2.7 ms +78.05%

@ematipico ematipico merged commit b120c98 into biomejs:main Apr 23, 2024
10 of 11 checks passed
@github-actions github-actions bot removed the A-Website Area: website label Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Linter Area: linter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants