Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(biome_css_analyzer): noDuplicateCustomProperties #2783

Conversation

chansuke
Copy link
Member

@chansuke chansuke commented May 9, 2024

Summary

Fixes #2806

Test Plan

@github-actions github-actions bot added A-Project Area: project L-CSS Language: CSS A-Diagnostic Area: diagnostocis labels May 9, 2024
Copy link

codspeed-hq bot commented May 9, 2024

CodSpeed Performance Report

Merging #2783 will degrade performances by 52.46%

Comparing chansuke:feat/declaration-block-no-duplicate-custom-properties (52bdeb4) with main (e50a3a4)

Summary

⚡ 1 improvements
❌ 4 regressions
✅ 102 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main chansuke:feat/declaration-block-no-duplicate-custom-properties Change
css_analyzer[bootstrap_18416142857265205439.css] 124.8 ms 252.1 ms -50.52%
css_analyzer[bulma_5641719244145477318.css] 433.1 ms 766.7 ms -43.52%
css_analyzer[foundation_11602414662825430680.css] 83 ms 158.1 ms -47.51%
css_analyzer[tachyons_11778168428173736564.css] 70.6 ms 148.4 ms -52.46%
pure_9395922602181450299.css[cached] 3.6 ms 3.3 ms +7.1%

@chansuke chansuke force-pushed the feat/declaration-block-no-duplicate-custom-properties branch from 8cb3658 to eebb582 Compare May 9, 2024 09:41
@ematipico
Copy link
Member

ematipico commented May 11, 2024

I wonder if we should start writing a semantic model.

I think this rule would benefit from it

@chansuke
Copy link
Member Author

@ematipico
Thank you for your feedback!
Would it be possible for me to contribute to the creation of a semantic model for CSS?

@ematipico
Copy link
Member

@ematipico Thank you for your feedback! Would it be possible for me to contribute to the creation of a semantic model for CSS?

Sure, I suggest talking with @togami2864, I know he has plans about it

@chansuke chansuke force-pushed the feat/declaration-block-no-duplicate-custom-properties branch 3 times, most recently from 988f795 to dd1f08d Compare September 6, 2024 08:28
@github-actions github-actions bot added the A-Changelog Area: changelog label Sep 6, 2024
@chansuke chansuke force-pushed the feat/declaration-block-no-duplicate-custom-properties branch from 3a1225d to 28d48db Compare September 6, 2024 10:53
@chansuke chansuke marked this pull request as ready for review September 6, 2024 11:31
Copy link
Contributor

@togami2864 togami2864 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linked issue is #2806, not #2784

@chansuke chansuke force-pushed the feat/declaration-block-no-duplicate-custom-properties branch from b51be39 to f9fdc49 Compare September 7, 2024 16:24
@chansuke chansuke merged commit 8179da2 into biomejs:main Sep 8, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Diagnostic Area: diagnostocis A-Project Area: project L-CSS Language: CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📎 Implement declaration-block-no-duplicate-custom-properties
4 participants