-
-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(biome_css_analyzer): noDuplicateCustomProperties
#2783
feat(biome_css_analyzer): noDuplicateCustomProperties
#2783
Conversation
CodSpeed Performance ReportMerging #2783 will degrade performances by 52.46%Comparing Summary
Benchmarks breakdown
|
8cb3658
to
eebb582
Compare
crates/biome_css_analyze/src/lint/nursery/no_duplicate_custom_properties.rs
Outdated
Show resolved
Hide resolved
I wonder if we should start writing a semantic model. I think this rule would benefit from it |
@ematipico |
Sure, I suggest talking with @togami2864, I know he has plans about it |
988f795
to
dd1f08d
Compare
3a1225d
to
28d48db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
crates/biome_css_analyze/src/lint/nursery/no_duplicate_custom_properties.rs
Outdated
Show resolved
Hide resolved
crates/biome_css_analyze/src/lint/nursery/no_duplicate_custom_properties.rs
Outdated
Show resolved
Hide resolved
b51be39
to
f9fdc49
Compare
Summary
Fixes #2806
Test Plan