-
-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(biome_css_analyzer): useConsistentGridAreas
#2940
feat(biome_css_analyzer): useConsistentGridAreas
#2940
Conversation
CodSpeed Performance ReportMerging #2940 will degrade performances by 15.11%Comparing Summary
Benchmarks breakdown
|
75ac0e9
to
9387ff6
Compare
useConsistentGridAreas
useConsistentGridAreas
0bf01ba
to
f019279
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments
crates/biome_css_analyze/src/lint/nursery/use_consistent_grid_areas.rs
Outdated
Show resolved
Hide resolved
crates/biome_css_analyze/src/lint/nursery/use_consistent_grid_areas.rs
Outdated
Show resolved
Hide resolved
crates/biome_css_analyze/src/lint/nursery/use_consistent_grid_areas.rs
Outdated
Show resolved
Hide resolved
crates/biome_css_analyze/src/lint/nursery/use_consistent_grid_areas.rs
Outdated
Show resolved
Hide resolved
crates/biome_css_analyze/src/lint/nursery/use_consistent_grid_areas.rs
Outdated
Show resolved
Hide resolved
crates/biome_css_analyze/src/lint/nursery/use_consistent_grid_areas.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Could you rebase?
@togami2864 |
859a8e6
to
67f738d
Compare
67f738d
to
e89dc5b
Compare
Summary
Closes #2809
This rule consists of the following checks:
1.At least one cell token:
2.The same number of cell tokens per row:
Test Plan
Created test cases that cover the named-grid-areas-no-invalid rule and verified each detail on the playground.