Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(biome_css_analyzer): useConsistentGridAreas #2940

Merged
merged 6 commits into from
Jun 10, 2024

Conversation

chansuke
Copy link
Member

@chansuke chansuke commented May 21, 2024

Summary

Closes #2809

This rule consists of the following checks:

1.At least one cell token:

  • No empty grids
  • Each cell must be filled with a single token

2.The same number of cell tokens per row:

  • All rows must have the same number of cell tokens

Test Plan

Created test cases that cover the named-grid-areas-no-invalid rule and verified each detail on the playground.

  • just test-lintrule useConsistentGridAreas
  • just l
  • just f

@github-actions github-actions bot added A-CLI Area: CLI A-Project Area: project L-CSS Language: CSS A-Diagnostic Area: diagnostocis labels May 21, 2024
Copy link

codspeed-hq bot commented May 21, 2024

CodSpeed Performance Report

Merging #2940 will degrade performances by 15.11%

Comparing chansuke:feat/use-consistent-grid-areas (61bce61) with chansuke:feat/use-consistent-grid-areas (de4314b)

Summary

❌ 8 regressions
✅ 84 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark chansuke:feat/use-consistent-grid-areas chansuke:feat/use-consistent-grid-areas Change
css_analyzer[bootstrap.css] 212 ms 226.9 ms -6.58%
css_analyzer[bulma.css] 81.6 ms 92.4 ms -11.69%
css_analyzer[foundation.css] 50.6 ms 59.6 ms -15.11%
css_analyzer[pure.css] 5.5 ms 6.4 ms -14.28%
css_analyzer[tachyons.css] 36.2 ms 42.4 ms -14.66%
css_formatter[bootstrap.css] 104.2 ms 110.8 ms -6%
css_formatter[foundation.css] 69.6 ms 74.3 ms -6.3%
css_formatter[materialize.css] 76.5 ms 81.9 ms -6.51%

@chansuke chansuke force-pushed the feat/use-consistent-grid-areas branch from 75ac0e9 to 9387ff6 Compare May 26, 2024 04:03
@chansuke chansuke changed the title WIP: feat(biome_css_analyzer): useConsistentGridAreas feat(biome_css_analyzer): useConsistentGridAreas May 26, 2024
@chansuke chansuke force-pushed the feat/use-consistent-grid-areas branch 5 times, most recently from 0bf01ba to f019279 Compare May 28, 2024 14:01
@chansuke chansuke marked this pull request as ready for review May 29, 2024 05:40
@chansuke chansuke marked this pull request as draft May 29, 2024 20:26
@chansuke chansuke marked this pull request as ready for review June 3, 2024 21:33
Copy link
Contributor

@togami2864 togami2864 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments

@chansuke chansuke requested a review from togami2864 June 8, 2024 04:03
Copy link
Contributor

@togami2864 togami2864 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you rebase?

@chansuke
Copy link
Member Author

chansuke commented Jun 9, 2024

@togami2864
Ok!

@chansuke chansuke force-pushed the feat/use-consistent-grid-areas branch from 859a8e6 to 67f738d Compare June 9, 2024 15:25
@chansuke chansuke force-pushed the feat/use-consistent-grid-areas branch from 67f738d to e89dc5b Compare June 9, 2024 15:38
@chansuke chansuke requested a review from togami2864 June 9, 2024 16:25
@ematipico ematipico merged commit 4cf4300 into biomejs:main Jun 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CLI Area: CLI A-Diagnostic Area: diagnostocis A-Project Area: project L-CSS Language: CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📎 Implement named-grid-areas-no-invalid
3 participants