Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): force colours when running ci command #2943

Merged
merged 4 commits into from
May 22, 2024
Merged

Conversation

ematipico
Copy link
Member

Summary

Enforce the use of colours in the ci command.

Test Plan

We should be able to see colours in this CI run

@github-actions github-actions bot added the A-CLI Area: CLI label May 22, 2024
@ematipico
Copy link
Member Author

@github-actions github-actions bot added the A-Changelog Area: changelog label May 22, 2024
@ematipico
Copy link
Member Author

cc @dyc3

Sorry to ping you, I just wanted to let you know that I removed the parsing of editor config here 5f314e5 (#2943) because it was blocking pnpm check:apply command we have here:

biome/package.json

Lines 6 to 8 in b2fe7b4

"check:apply": "cargo biome-cli-dev check --apply-unsafe .",
"check": "cargo biome-cli-dev check .",
"ci": "cargo biome-cli-dev ci ."

@ematipico ematipico merged commit 417a174 into main May 22, 2024
14 checks passed
@ematipico ematipico deleted the feat/force-colors-ci branch May 22, 2024 11:15
@dyc3
Copy link
Contributor

dyc3 commented May 23, 2024

@ematipico Thanks for letting me know, I'll add this to the todo list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-CLI Area: CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants