-
-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(biome_css_analyzer): noShorthandPropertyOverrides #2958
Merged
ematipico
merged 14 commits into
biomejs:main
from
neoki07:feat/no-shorthand-property-overrides
Jun 10, 2024
Merged
feat(biome_css_analyzer): noShorthandPropertyOverrides #2958
ematipico
merged 14 commits into
biomejs:main
from
neoki07:feat/no-shorthand-property-overrides
Jun 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Project
Area: project
L-CSS
Language: CSS
A-Diagnostic
Area: diagnostocis
labels
May 23, 2024
neoki07
force-pushed
the
feat/no-shorthand-property-overrides
branch
from
May 29, 2024 12:32
4fac6ab
to
8df660d
Compare
CodSpeed Performance ReportMerging #2958 will degrade performances by 16.26%Comparing Summary
Benchmarks breakdown
|
neoki07
commented
May 29, 2024
crates/biome_css_analyze/tests/specs/nursery/noShorthandPropertyOverrides/invalid.css
Outdated
Show resolved
Hide resolved
crates/biome_css_analyze/tests/specs/nursery/noShorthandPropertyOverrides/invalid.css
Outdated
Show resolved
Hide resolved
crates/biome_css_analyze/tests/specs/nursery/noShorthandPropertyOverrides/invalid.css
Outdated
Show resolved
Hide resolved
crates/biome_css_analyze/src/lint/nursery/no_shorthand_property_overrides.rs
Outdated
Show resolved
Hide resolved
neoki07
force-pushed
the
feat/no-shorthand-property-overrides
branch
from
June 1, 2024 05:56
9010ac4
to
41eacf2
Compare
togami2864
reviewed
Jun 4, 2024
crates/biome_css_analyze/src/lint/nursery/no_shorthand_property_overrides.rs
Outdated
Show resolved
Hide resolved
crates/biome_css_analyze/src/lint/nursery/no_shorthand_property_overrides.rs
Outdated
Show resolved
Hide resolved
neoki07
force-pushed
the
feat/no-shorthand-property-overrides
branch
from
June 5, 2024 11:50
fe06e4c
to
f1e27dd
Compare
ematipico
approved these changes
Jun 10, 2024
neoki07
changed the title
feat(biome_css_analyze): noShorthandPropertyOverrides
feat(biome_css_analyzer): noShorthandPropertyOverrides
Jun 10, 2024
I believe we can accept the regressions for now |
@neokidev can you send a PR to update the changelog? |
@ematipico I created the PR(#3163). |
This was referenced Aug 28, 2024
This was referenced Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
close #2807
Implement declaration-block-no-shorthand-property-overrides
Test Plan
added tests and snapshots