feat(biome_css_analyzer): implement selector-pseudo-class-no-unknown #3034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Project
CodSpeed Performance ReportMerging #3034 will not alter performanceComparing Summary
|
tunamaguro
commented
Jun 1, 2024
Comment on lines
72
to
91
| fn is_webkit_pseudo_class(node: &AnyPseudoLike) -> bool { | ||
| let mut prev_element = node.syntax().parent().and_then(|p| p.prev_sibling()); | ||
| while let Some(prev) = &prev_element { | ||
| let maybe_selector: Option<CssPseudoElementSelector> = prev.clone().cast(); | ||
| if let Some(selector) = maybe_selector.as_ref() { | ||
| return WEBKIT_SCROLLBAR_PSEUDO_ELEMENTS.contains(&selector.text().trim_matches(':')); | ||
| }; | ||
| prev_element = prev.prev_sibling(); | ||
| } | ||
|
|
||
| false | ||
| } |
There was a problem hiding this comment.
To determine whether a ::-webkit-scrollbar CSS pseudo-element has a selector, I'm retrieving each previous element one by one, but I feel there might be a performance issue.
togami2864
reviewed
Jun 4, 2024
Comment on lines
65
to
78
| declare_node_union! { | ||
| pub AnyPseudoLike = CssPseudoClassFunctionCompoundSelector|CssPseudoClassFunctionCompoundSelectorList|CssPseudoClassFunctionIdentifier | ||
| |CssPseudoClassFunctionNth|CssPseudoClassFunctionRelativeSelectorList|CssPseudoClassFunctionSelector | ||
| |CssPseudoClassFunctionSelectorList|CssPseudoClassFunctionValueList|CssPseudoClassIdentifier | ||
| |CssBogusPseudoClass|CssPageSelectorPseudo | ||
| } |
There was a problem hiding this comment.
Suggested change
| declare_node_union! { | |
| pub AnyPseudoLike = CssPseudoClassFunctionCompoundSelector|CssPseudoClassFunctionCompoundSelectorList|CssPseudoClassFunctionIdentifier | |
| |CssPseudoClassFunctionNth|CssPseudoClassFunctionRelativeSelectorList|CssPseudoClassFunctionSelector | |
| |CssPseudoClassFunctionSelectorList|CssPseudoClassFunctionValueList|CssPseudoClassIdentifier | |
| |CssBogusPseudoClass|CssPageSelectorPseudo | |
| } | |
| declare_node_union! { | |
| pub AnyPseudoLike = | |
| CssPseudoClassFunctionCompoundSelector | |
| | CssPseudoClassFunctionCompoundSelectorList | |
| | CssPseudoClassFunctionIdentifier | |
| | CssPseudoClassFunctionNth | |
| | CssPseudoClassFunctionRelativeSelectorList | |
| | CssPseudoClassFunctionSelector | |
| | CssPseudoClassFunctionSelectorList | |
| | CssPseudoClassFunctionValueList | |
| | CssPseudoClassIdentifier | |
| | CssBogusPseudoClass | |
| | CssPageSelectorPseudo | |
| } |
There was a problem hiding this comment.
Thank you for the suggestions. I fixed it in 8a79444
| fn is_webkit_pseudo_class(node: &AnyPseudoLike) -> bool { | ||
| let mut prev_element = node.syntax().parent().and_then(|p| p.prev_sibling()); | ||
| while let Some(prev) = &prev_element { | ||
| let maybe_selector: Option<CssPseudoElementSelector> = prev.clone().cast(); |
There was a problem hiding this comment.
Suggested change
| let maybe_selector: Option<CssPseudoElementSelector> = prev.clone().cast(); | |
| let maybe_selector = CssPseudoElementSelector::cast_ref(prev); |
There was a problem hiding this comment.
Thank you for the suggestions. I fixed it in 4eae3f0
| a:pseudo-class { } | ||
| body:not(div):noot(span) {} | ||
| a:unknown::before { } | ||
| a,\nb > .foo:error { } |
There was a problem hiding this comment.
Suggested change
| a,\nb > .foo:error { } | |
| a, | |
| b > .foo:error { } |
There was a problem hiding this comment.
I fixed it in 3144105 and update snapshots
| div :nth-child(2 of .widget) { } | ||
| a:hover::before { } | ||
| a:-moz-placeholder { } | ||
| a,\nb > .foo:hover { } |
There was a problem hiding this comment.
Suggested change
| a,\nb > .foo:hover { } | |
| a, | |
| b > .foo:hover { } |
There was a problem hiding this comment.
I fixed it in 3144105 and update snapshots
| version: "next", | ||
| name: "noUnknownPseudoClassSelector", | ||
| language: "css", | ||
| recommended: false, |
There was a problem hiding this comment.
Suggested change
| recommended: false, | |
| recommended: true, |
There was a problem hiding this comment.
I fixed it in 83e8e9f
tunamaguro
force-pushed
the
feat/css-selector-pseudo-class-no-unknown
branch
from
83e8e9f
to
7db746b
Compare
|
@togami2864 |
togami2864
approved these changes
Jun 6, 2024
crates/biome_css_analyze/src/lint/nursery/no_unknown_pseudo_class_selector.rs
Outdated
Show resolved
Hide resolved
…ass_selector.rs Co-authored-by: ty <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
close #2625
implement selector-pseudo-class-no-unknown
Test Plan
Add test cases from
stylelint: https://github.com/stylelint/stylelint/blob/main/lib/rules/selector-pseudo-class-no-unknown/__tests__/index.mjs