Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useAdjacentOverloadSignatures): don't report #private and public members with same name #3459

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

Conaclos
Copy link
Member

Summary

Fix #3309
I introduced a new enum ClassMemberName that is returned by AnyJsClassMemberName::name.
This allows to carry the information if the name was #private or public.
I had to refactor the code of useAdjacentOverloadSignatures to accommodate with this change.

I also fixed noMisleadingInstantiator that previously reported class C { #new(): C {} }.

Test Plan

I added tests.

@github-actions github-actions bot added A-Linter Area: linter A-Parser Area: parser L-JavaScript Language: JavaScript and super languages A-Changelog Area: changelog labels Jul 17, 2024
Copy link
Contributor

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 48326 48326 0
Passed 47129 47129 0
Failed 1197 1197 0
Panics 0 0 0
Coverage 97.52% 97.52% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6549 6549 0
Passed 2201 2201 0
Failed 4348 4348 0
Panics 0 0 0
Coverage 33.61% 33.61% 0.00%

ts/babel

Test result main count This PR count Difference
Total 669 669 0
Passed 597 597 0
Failed 72 72 0
Panics 0 0 0
Coverage 89.24% 89.24% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 18273 18273 0
Passed 14007 14007 0
Failed 4266 4266 0
Panics 0 0 0
Coverage 76.65% 76.65% 0.00%

Copy link

codspeed-hq bot commented Jul 17, 2024

CodSpeed Performance Report

Merging #3459 will not alter performance

Comparing conaclos/useAdjacentOverloadSignatures-3309 (3d77efb) with main (7188856)

Summary

✅ 104 untouched benchmarks

@Conaclos Conaclos merged commit ba8aabc into main Jul 17, 2024
16 checks passed
@Conaclos Conaclos deleted the conaclos/useAdjacentOverloadSignatures-3309 branch July 17, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Linter Area: linter A-Parser Area: parser L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💅 useAdjacentOverloadSignatures does not distinguish between public and private fields.
1 participant