fix(useAdjacentOverloadSignatures): don't report #private and public members with same name #3459
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #3309
I introduced a new enum
ClassMemberName
that is returned byAnyJsClassMemberName::name
.This allows to carry the information if the name was #private or public.
I had to refactor the code of
useAdjacentOverloadSignatures
to accommodate with this change.I also fixed
noMisleadingInstantiator
that previously reportedclass C { #new(): C {} }
.Test Plan
I added tests.