-
-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(useFilenamingConvention): support dynamic route filenames #3466
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any chance we can support SolidStart too? They use a different approach... 😓
https://docs.solidjs.com/solid-start/building-your-application/routing#renaming-index
CodSpeed Performance ReportMerging #3466 will not alter performanceComparing Summary
|
I will take a look. |
Ehehe, you're aren't wrong 😅 |
4075f62
to
e89cd00
Compare
Just to add svelte kit also uses |
Is (app) a placeholder?
Could you detail the syntax?
|
Anything after I also think this should be supported only for svelte files since it is quite unusual syntax. I am not 100% garunateed, but I can't find anything for non svelte files on search. svelte files using that pattern for reference. |
e89cd00
to
46f6378
Compare
I am going to merge this PR. I will consider extending the rule with a configuration to customize the accepted patterns. |
Summary
Fix #3465
I had to modify the way we generate test names. To have a more robust approach, we now rely on
biome_string_case
case conversion. I had to change some test name to accommodate with this change.Test Plan
I added four tests.