Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js_formatter): remove useless parens around infer type #3693

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

Conaclos
Copy link
Member

Summary

Fix a regression introduced in #3451 and detected by the Ecosystem CI

Test Plan

I added a test.

@github-actions github-actions bot added A-Parser Area: parser A-Formatter Area: formatter L-JavaScript Language: JavaScript and super languages A-Changelog Area: changelog labels Aug 21, 2024
Copy link
Contributor

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 48506 48506 0
Passed 47309 47309 0
Failed 1197 1197 0
Panics 0 0 0
Coverage 97.53% 97.53% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6568 6568 0
Passed 2201 2201 0
Failed 4367 4367 0
Panics 0 0 0
Coverage 33.51% 33.51% 0.00%

ts/babel

Test result main count This PR count Difference
Total 670 670 0
Passed 598 598 0
Failed 72 72 0
Panics 0 0 0
Coverage 89.25% 89.25% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 18411 18411 0
Passed 14094 14094 0
Failed 4317 4317 0
Panics 0 0 0
Coverage 76.55% 76.55% 0.00%

@Conaclos Conaclos merged commit 14c7d97 into main Aug 21, 2024
15 checks passed
@Conaclos Conaclos deleted the conaclos/remove-useless-parens-around-infer branch August 21, 2024 15:14
Copy link

codspeed-hq bot commented Aug 21, 2024

CodSpeed Performance Report

Merging #3693 will not alter performance

Comparing conaclos/remove-useless-parens-around-infer (033ba55) with main (2b39048)

Summary

✅ 101 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Formatter Area: formatter A-Parser Area: parser L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant