Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useValidAriaValues): correctly check property types #3768

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

Conaclos
Copy link
Member

@Conaclos Conaclos commented Sep 3, 2024

Summary

Fix #3748

This PR fixes several bugs and improves the diagnostics of useValidAriaValues.

  • Properties that expect a string now accept arbitrary text.
  • An identifiers can now be made up of any characters except ASCII whitespace.
  • An identifier list can now be separated by any ASCII whitespace.

Test Plan

I added some tests.

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages A-Changelog Area: changelog labels Sep 3, 2024
Copy link

codspeed-hq bot commented Sep 3, 2024

CodSpeed Performance Report

Merging #3768 will not alter performance

Comparing conaclos/useValidAriaValues-3748 (fd8fcd9) with main (35e9e6d)

Summary

✅ 99 untouched benchmarks

@Conaclos Conaclos merged commit e79ecce into main Sep 3, 2024
15 checks passed
@Conaclos Conaclos deleted the conaclos/useValidAriaValues-3748 branch September 3, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Linter Area: linter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💅 aria-keyshortcuts with single numeric char doesn't pass a11y linter
1 participant