Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve documentation of rule #3999

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Conversation

ematipico
Copy link
Member

Summary

Closes #3476

Test Plan

N/A

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Sep 19, 2024
@ematipico ematipico merged commit a3193e7 into main Sep 19, 2024
14 checks passed
@ematipico ematipico deleted the docs/improve-rule-top-level branch September 19, 2024 15:33
Copy link

codspeed-hq bot commented Sep 19, 2024

CodSpeed Performance Report

Merging #3999 will degrade performances by 6.36%

Comparing docs/improve-rule-top-level (bf7682e) with main (6922305)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 105 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main docs/improve-rule-top-level Change
router_17129688031671448157.ts[cached] 2.1 ms 2.2 ms -6.36%
eucjp_1600564308684076393.json[uncached] 1,190.2 µs 964.7 µs +23.38%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Linter Area: linter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useHookAtTopLevel reports errors on code that is not React
1 participant