feat(linter): support useGuardForIn #4104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Project
CodSpeed Performance ReportMerging #4104 will not alter performanceComparing Summary
|
ematipico
requested changes
Sep 27, 2024
fireairforce
changed the title
fireairforce
force-pushed
the
feat-3933
branch
from
6cb63b9
to
649c7d2
Compare
|
sorry i miss the rule name convention for biome, i update the lint name now, please review again when you free~ @ematipico |
ematipico
requested changes
Sep 27, 2024
crates/biome_js_analyze/tests/specs/nursery/useGuardForIn/invalid.js.snap
Outdated
Show resolved
Hide resolved
crates/biome_js_analyze/tests/specs/nursery/useGuardForIn/invalid.js.snap
Outdated
Show resolved
Hide resolved
fireairforce
force-pushed
the
feat-3933
branch
from
47242b3
to
0c0be67
Compare
ematipico
reviewed
Sep 30, 2024
There was a problem hiding this comment.
Shouldn't we add cases where we have a for..in loop with Object.hasOwn(foo, key), for example?
There was a problem hiding this comment.
updated~ thanks for review
fireairforce
force-pushed
the
feat-3933
branch
from
2fca630
to
f6d18bb
Compare
ematipico
approved these changes
Oct 9, 2024
github-actions
bot
added
A-Project
fireairforce
force-pushed
the
feat-3933
branch
from
8e936f3
to
2cfc0ee
Compare
|
i solve the conflict at my local, maybe the mr can be merged later? |
fireairforce
force-pushed
the
feat-3933
branch
from
2cfc0ee
to
06b5bbd
Compare
fireairforce
force-pushed
the
feat-3933
branch
from
06b5bbd
to
3dc2528
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes: #3933
Test Plan