refactor(cli): command runner #4198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-CLI
Conaclos
approved these changes
Oct 7, 2024
arendjr
approved these changes
Oct 7, 2024
crates/biome_cli/tests/snapshots/main_commands_migrate/should_create_biome_json_file.snap
Outdated
Show resolved
Hide resolved
CodSpeed Performance ReportMerging #4198 will improve performances by 7.29%Comparing Summary
Benchmarks breakdown
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR migrates the majority of commands to use the
CommandRunnertrait.I also created a new trait called
LoadEditorConfigto share the same logic only for theformat,checkandcicommands, where we load the.editorconfigfile.Test Plan
Current CI should work. Checked that the updated snapshots are correct.