Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useImportType): remove useless inline type import qualifier #4201

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

Conaclos
Copy link
Member

@Conaclos Conaclos commented Oct 7, 2024

Summary

Fix #4178

Test Plan

I added tests.

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages A-Changelog Area: changelog labels Oct 7, 2024
@Conaclos Conaclos force-pushed the conaclos/useImportType-useless-type-imports branch from 6b001cb to 58936bd Compare October 7, 2024 16:10
Copy link

codspeed-hq bot commented Oct 7, 2024

CodSpeed Performance Report

Merging #4201 will not alter performance

Comparing conaclos/useImportType-useless-type-imports (88a640c) with main (bae50d1)

Summary

✅ 105 untouched benchmarks

@Conaclos Conaclos force-pushed the conaclos/useImportType-useless-type-imports branch from 58936bd to 88a640c Compare October 7, 2024 20:27
@Conaclos Conaclos merged commit 48affbb into main Oct 7, 2024
11 checks passed
@Conaclos Conaclos deleted the conaclos/useImportType-useless-type-imports branch October 7, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Linter Area: linter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💅 useImportType fails to remove inline type imports when the group also uses a type import
2 participants