-
-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: plugin loader #4234
feat: plugin loader #4234
Conversation
CodSpeed Performance ReportMerging #4234 will degrade performances by 6.8%Comparing Summary
Benchmarks breakdown
|
12821d7
to
b1543c4
Compare
Should we change the destination of the PR to |
b1543c4
to
f8c4a0b
Compare
I've rebased onto |
Btw, thinking of the whole manifest thing, while I like this approach for future compatibility and the ability to publish plugins, I think I’ll still implement the ability to refer to refer to Grit files directly from the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the PR should be rebased because there are changes that don't belong here
@@ -0,0 +1,32 @@ | |||
[package] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's possible you created the crate manually or with cargo. If so you, you need to update manually knope.toml
and add the crate. We have just new-crate
that updates the file automatically
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
trait RangeExt { | ||
fn to_text_range(self) -> TextRange; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation is missing: the trait and the function.
plugin ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ | ||
|
||
× Cannot load plugin manifest | ||
|
||
Caused by: | ||
version must be 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these snapshots could be improved by providing the input/files provided.
f8c4a0b
to
30f85a4
Compare
bd7f2e1
to
9a3d4a5
Compare
3264f2f
to
2b9a69f
Compare
9a3d4a5
to
1602a76
Compare
Summary
Continuation of #4071
Note this doesn't integrate the plugins into the analyzer yet, like the previous one did. This just makes sure they load as we want them to.
Test Plan
Tests added. CI should remain green.