Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update rust crate rustc-hash to v2 #4284

Merged
merged 4 commits into from
Oct 30, 2024
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 14, 2024

This PR contains the following updates:

Package Type Update Change
rustc-hash workspace.dependencies major 1.1.0 -> 2.0.0

Release Notes

rust-lang/rustc-hash (rustc-hash)

v2.0.0

Compare Source

  • Replace hash with faster and better finalized hash.
    This replaces the previous "fxhash" algorithm originating in Firefox
    with a custom hasher designed and implemented by Orson Peters (@orlp).
    It was measured to have slightly better performance for rustc, has better theoretical properties
    and also includes a significantly better string hasher.
  • Fix no_std builds

v1.2.0

Note: This version has been yanked due to issues with the no_std feature!

  • Add a FxBuildHasher unit struct
  • Improve documentation
  • Add seed API for supplying custom seeds other than 0
  • Add FxRandomState based on rand (behind the rand feature) for random seeds
  • Make many functions const fn
  • Implement Clone for FxHasher struct

Configuration

📅 Schedule: Branch creation - "before 9am on monday" in timezone Europe/Gibraltar, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Copy link
Contributor Author

renovate bot commented Oct 30, 2024

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: Cargo.lock
Command failed: cargo update --config net.git-fetch-with-cli=true --manifest-path Cargo.toml --package [email protected] --precise 2.0.0
    Updating crates.io index
error: failed to select a version for the requirement `rustc-hash = "^1.1"`
candidate versions found which didn't match: 2.0.0
location searched: crates.io index
required by package `countme v3.0.1`
    ... which satisfies dependency `countme = "^3.0.1"` (locked to 3.0.1) of package `biome_css_formatter v0.5.7 (/tmp/renovate/repos/github/biomejs/biome/crates/biome_css_formatter)`
    ... which satisfies path dependency `biome_css_formatter` (locked to 0.5.7) of package `biome_cli v0.0.0 (/tmp/renovate/repos/github/biomejs/biome/crates/biome_cli)`

@ematipico
Copy link
Member

It seems the new hash changed the ordering algorithm, and the snapshots are failing

@github-actions github-actions bot added the A-CLI Area: CLI label Oct 30, 2024
@github-actions github-actions bot added the A-Project Area: project label Oct 30, 2024
Copy link

codspeed-hq bot commented Oct 30, 2024

CodSpeed Performance Report

Merging #4284 will not alter performance

Comparing renovate/rustc-hash-2.x (b65b61d) with main (044baf4)

Summary

✅ 99 untouched benchmarks

Copy link
Contributor Author

renovate bot commented Oct 30, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@Conaclos Conaclos self-assigned this Oct 30, 2024
@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Oct 30, 2024
@Conaclos Conaclos merged commit 1b602dc into main Oct 30, 2024
3 checks passed
@Conaclos Conaclos deleted the renovate/rustc-hash-2.x branch October 30, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CLI Area: CLI A-Linter Area: linter A-Project Area: project L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants