Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(grit): add range formatting #4525

Merged
merged 2 commits into from
Nov 13, 2024
Merged

feat(grit): add range formatting #4525

merged 2 commits into from
Nov 13, 2024

Conversation

ematipico
Copy link
Member

Summary

This PR adds range formatting and format on type for grit

Test Plan

Existing CI should pass

@github-actions github-actions bot added A-Project Area: project A-Formatter Area: formatter L-Grit Language: GritQL labels Nov 13, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 13, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #4525 will not alter performance

Comparing feat/add-range-formatting (4e99eea) with main (9611497)

Summary

✅ 97 untouched benchmarks

🆕 2 new benchmarks

Benchmarks breakdown

Benchmark main feat/add-range-formatting Change
🆕 typescript_5583633924076080079.js[cached] N/A 938.2 ms N/A
🆕 typescript_5583633924076080079.js[uncached] N/A 1 s N/A

chansuke
chansuke approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@chansuke chansuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

arendjr
arendjr approved these changes Nov 13, 2024
View reviewed changes
crates/biome_grit_formatter/src/lib.rs Outdated Show resolved Hide resolved
crates/biome_grit_formatter/src/lib.rs Outdated Show resolved Hide resolved
@ematipico @arendjr
Apply suggestions from code review
4e99eea 
Co-authored-by: Arend van Beelen jr. <[email protected]>
@ematipico ematipico merged commit 6d75a4c into main Nov 13, 2024
11 checks passed
@ematipico ematipico deleted the feat/add-range-formatting branch November 13, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arendjr arendjr arendjr approved these changes

@chansuke chansuke chansuke approved these changes

Assignees
No one assigned
Labels
A-Formatter Area: formatter A-Project Area: project L-Grit Language: GritQL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ematipico @chansuke @arendjr