fix(json_parser): fix broken JsonParserOptions::from(&JsonFileSource)
implementation
#4540
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes incorrect use of
with_*
methods inJsonParserOptions::from(&JsonFileSource)
. Adds unit tests and#[must_use]
to prevent this error in the future.I accidentally stumbled upon this while trying to fix some tests that were breaking due to an unrelated change. Took a bit of time to figure out that
JsonParserOptions::from
simply discarded theallow_comments
andallow_trailing_commas
flags...Test Plan
Unit tests for
JsonParserOptions::from(&JsonFileSource)
were added.