Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replicate subpackage structure #92

Open
huard opened this issue Dec 5, 2018 · 2 comments
Open

Replicate subpackage structure #92

huard opened this issue Dec 5, 2018 · 2 comments
Labels
enhancement ESGF Earth System Grid Federation question

Comments

@huard
Copy link
Contributor

huard commented Dec 5, 2018

Description

Some processes use a hierarchical naming convention (CDAT.aggregate). I suggest we mimic this by creating this mock hierarchy, ie. wps.cdat.aggregate instead of sanitizing names to cdat_aggregate

@cehbrecht
Copy link
Member

... this means we would generate a namespace with "artificial" packages? It needs to be a valid Python expression.

There is unfortunately no recommendation or restriction how to define WPS identifiers. All we know is, we get a string ;) We can try to establish a "good practice" for our own services ... but in case of birdy, we need to be fail-safe.

@huard
Copy link
Contributor Author

huard commented Dec 6, 2018

Yes

and that's a problem. We probably should have a dictionary accessor where the original name of the process is conserved.

Maybe we need to think about this more.

@huard huard added the ESGF Earth System Grid Federation label Jan 29, 2019
Zeitsperre added a commit that referenced this issue Oct 28, 2019
* Added pytest-notebook requirements, makefile recipe, and regex rules

* Updated notebooks and moved requirements to github masters

* Added tests to travis loadout

* Allow parsing github links in requirements

* add nbval to env

* added sanitize code for agu notebook

* Or true for test-nb

* Drop Python3.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ESGF Earth System Grid Federation question
Projects
None yet
Development

No branches or pull requests

2 participants